Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add codecov #920

Merged
merged 1 commit into from
Oct 14, 2024
Merged

Add codecov #920

merged 1 commit into from
Oct 14, 2024

Conversation

natemort
Copy link
Member

@natemort natemort commented Oct 11, 2024

What changed?
Add a github workflow to run codecov to generate code coverage reports on pull requests.

Rather than running the tests directly we need to run them via docker to account for the thrift dependencies that are otherwise painful to set up.

Why?
Make it easier to track and enforce code coverage requirements.

How did you test it?
Creating this PR, hopefully it works.

Potential risks

Release notes

Documentation Changes

@coveralls
Copy link

coveralls commented Oct 11, 2024

Pull Request Test Coverage Report for Build 2522

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.01%) to 62.011%

Files with Coverage Reduction New Missed Lines %
src/main/java/com/uber/cadence/internal/worker/LocallyDispatchedActivityPollTask.java 2 39.02%
Totals Coverage Status
Change from base Build 2458: -0.01%
Covered Lines: 12094
Relevant Lines: 19503

💛 - Coveralls

Copy link

codecov bot commented Oct 11, 2024

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@natemort natemort merged commit c6891e2 into cadence-workflow:master Oct 14, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants