-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
E2e fixes #132
Conversation
3cdb746
to
c9b8a2f
Compare
ea070c2
to
362843b
Compare
ENV PATH=/go/dela/cli/crypto:/go/d-voting/cli/dvoting:${PATH} | ||
RUN --mount=type=cache,target="/root/.cache/go-build" go install | ||
# make sure we're using the same head as d-voting | ||
RUN --mount=type=cache,target="/root/.cache/go-build" cd $( go list -f '{{.Dir}}' go.dedis.ch/dela )/cli/crypto && go install |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isn't that a different DELA repository now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
go does some magic here:
$ go list -f '{{.Dir}}' go.dedis.ch/dela
.../packages/pkg/mod/github.com/c4dt/[email protected]
and because we kept the go.dedis.ch/dela
as package name throughout the github.com/c4dt/d-voting
, and rely on the replace
directive in go.mod
, I think it's OK.
Change my mind :)
This also updates some of the outdated settings in the frontend
This PR does the following:
Thank you for opening a pull request with this project, please also:
Review hint
Each commit should be understandable on its own.
draft
mode andin progress
pipeline in the project (if applicable)Review
orReady4Merge
pipeline in the project (if applicable)draft