Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2e fixes #132

Merged
merged 8 commits into from
Mar 1, 2024
Merged

E2e fixes #132

merged 8 commits into from
Mar 1, 2024

Conversation

ineiti
Copy link
Member

@ineiti ineiti commented Feb 28, 2024

This PR does the following:

  • Comments and error handling
  • Improve speed of docker build
  • Add voting script to the backend
  • Putting FormFromStore into a single place
  • Correctly store and retrieve DKGs
  • Synching of nonces is now done in dela
  • Making tests pass

Thank you for opening a pull request with this project, please also:

Review hint

Each commit should be understandable on its own.

  • add a brief description of your changes here
  • assign the PR to yourself, or to the person(s) working on it
  • start in draft mode and in progress pipeline in the project (if applicable)
  • if applicable, add this PR to its related issue by one of the special keywords Closing keywords
  • once it's ready
    • put it in the Review or Ready4Merge pipeline in the project (if applicable)
    • remove draft
    • assign a reviewer

@ineiti ineiti self-assigned this Feb 28, 2024
@ineiti ineiti force-pushed the separate_ballots branch 2 times, most recently from 3cdb746 to c9b8a2f Compare February 28, 2024 15:29
@ineiti ineiti force-pushed the e2e_fixes branch 3 times, most recently from ea070c2 to 362843b Compare February 29, 2024 12:43
@ineiti ineiti marked this pull request as ready for review February 29, 2024 13:02
@ineiti ineiti requested a review from PascalinDe February 29, 2024 13:03
ENV PATH=/go/dela/cli/crypto:/go/d-voting/cli/dvoting:${PATH}
RUN --mount=type=cache,target="/root/.cache/go-build" go install
# make sure we're using the same head as d-voting
RUN --mount=type=cache,target="/root/.cache/go-build" cd $( go list -f '{{.Dir}}' go.dedis.ch/dela )/cli/crypto && go install
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't that a different DELA repository now?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

go does some magic here:

$ go list -f '{{.Dir}}' go.dedis.ch/dela
.../packages/pkg/mod/github.com/c4dt/[email protected]

and because we kept the go.dedis.ch/dela as package name throughout the github.com/c4dt/d-voting, and rely on the replace directive in go.mod, I think it's OK.

Change my mind :)

web/backend/src/cli.ts Outdated Show resolved Hide resolved
@ineiti ineiti force-pushed the separate_ballots branch from c9b8a2f to 76d53c1 Compare March 1, 2024 12:04
@PascalinDe PascalinDe self-requested a review March 1, 2024 12:21
services/dkg/pedersen/handler.go Show resolved Hide resolved
Base automatically changed from separate_ballots to main March 1, 2024 12:29
@ineiti ineiti merged commit ae9e179 into main Mar 1, 2024
11 checks passed
@ineiti ineiti deleted the e2e_fixes branch March 1, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants