Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing CORS headers when write actions are rejected #720

Open
asaunier opened this issue Feb 1, 2018 · 2 comments
Open

Missing CORS headers when write actions are rejected #720

asaunier opened this issue Feb 1, 2018 · 2 comments

Comments

@asaunier
Copy link
Member

asaunier commented Feb 1, 2018

See also c2corg/v6_ui#1989 (comment)

Tested in prod, demo and in a personal instance:

  • if a write action is accepted, nothing special is reported on the UI side in browsers' dev consoles
  • on the other hand, if the write action is rejected (blocked or rate limited user, 500 error?), the UI error processing is not performed as expected (Add support of rate limiting message v6_ui#1989) and CORS errors are reported in the browsers' dev consoles:

capture du 2018-01-31 20-06-37

It seems CORS headers are not returned when an exception is raised while processing the request.

  • failed request (user is blocked):

capture du 2018-02-01 11-15-59

  • successful request:

capture du 2018-02-01 11-17-35

@asaunier
Copy link
Member Author

asaunier commented Feb 1, 2018

See investigations about CORS starting at c2corg/v6_ui#1989 (comment)

@lbesson
Copy link
Member

lbesson commented May 3, 2021

see #1073 and Cornices/cornice#115

Updating cornice will probably solve the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants