-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migration of the outings associated to climbing sites #351
Comments
Makes sense. |
This topic should be considered quite soon, it's rather important. |
The following would have to be done: For all climbing sites (waypoint type = climbing_outdoor or climbing_indoor) that are associated to outings, create fake routes:
[edited] |
Makes sense. Thanks for the analysis! |
@asaunier @tsauerwein when do you plan ? |
I was planning to tackle this today. |
@stef74 @fbunoz what name do you recommend for the fake routes? @tsauerwein has observed that since the climbing site will be set as the main waypoint, its name will be displayed as prefix in the route name, so it's not relevant to reuse the site name as the fake route name. |
In the description we could also show a link that points to an article that explains the idea behind "dummy/fake" routes for climbing sites. It would be up to the association to create such article. |
If such an article is created, it should be added in v5 because the document_id must be available before running the migration. |
Should the created dummy/fake route be protected, so that only moderators can modify it? |
No, all outings associated with a climbing site must be treated. In V5, we can associate an outing to 1 or several routes AND to 1 or several sites : http://www.camptocamp.org/outings/list/routes/+/sites/+
Yes : http://www.camptocamp.org/articles/822764/fr/saisir-une-sortie-couenne-sur-la-v6
undefined ? :) |
Not only before the migration, but before this issue is closed = ASAP = before monday, thanks :) |
@tsauerwein What about the outings that are associated to several climbing sites? For instance http://www.camptocamp.org/outings/538678/fr/j3-a-fontainebleau-trois-pignons-circuit-jaune-pd-du-rocher-des-potets-puis-petit-tour-au-91-1 |
Ok, no problem. That makes the query even easier.
Yes. That would be in line with what @fbunoz said above ("During the migration, these outings must keep all their associations"). |
The feedback from the association about the dummy route :
|
@shortoland @loicperrin @fbunoz please test |
I verified that all rock climbing outings are georeferenced (using the carto and comparing with not using the carto, it is not friendly as there is a bug on doc count when with zoom on whole world). |
What do you mean? Is there an issue describing it?
Could you please precise what is actually preventing from closing the issue? |
Yes : #538
We must check that the outings are associated to the dummy route of the right climbing site, and that an outing associated to a V5 route and a V5 site is migrated correctly, and another things. |
In v5, it is possible to create an outing from a "climbing site" page => no route is associated to the outing. See for instance: http://www.camptocamp.org/outings/538339/fr/gaillands (associated to the climbing site http://www.camptocamp.org/sites/102326/fr/gaillands)
In v6:
@tsauerwein do you think it would be possible when migrating such outings (not associated to a route but to a climbing site) to create a basic route (if not already existing) which would be named the same way than the climbing_site waypoint and to associate it between the WP and the outing?
(Of course we could keep the current way those outings are migrated if the above solution is too complicated - I didn't realize until now it was possible- but that would be a bit confusing and not consistent to have those old outings still associated to the climbing site waypoints.)
The text was updated successfully, but these errors were encountered: