Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show associated images on image view #396

Closed
asaunier opened this issue Nov 6, 2016 · 8 comments
Closed

Show associated images on image view #396

asaunier opened this issue Nov 6, 2016 · 8 comments
Labels
good first issue Good for newcomers imported from v6 Issue created on v6 repo
Milestone

Comments

@asaunier
Copy link
Member

asaunier commented Nov 6, 2016

In v5 it's possible to associate an image to another (for instance to associate a drawing with the original image). For instance:
http://www.camptocamp.org/images/208579/fr/face-n-des-grandes-jorasses-quelques-itineraires
http://www.camptocamp.org/images/188564/fr/face-nord-des-grandes-jorasses

As for now I don't think it's possible in v6.

@fbunoz
Copy link
Contributor

fbunoz commented Nov 23, 2016

The associated images don't appear in the linked docs : https://www.demov6.camptocamp.org/images/208579/fr/face-n-des-grandes-jorasses-quelques-itineraires

The association has been migrated correctly ?

@tsauerwein
Copy link
Member

The association has been migrated correctly ?

For example for https://www.demov6.camptocamp.org/routes/557726/fr/grandes-jorasses-pointe-walker-colton-mcintyre your image is returned by the API: http://api.demov6.camptocamp.org/routes/557726

But it seems that the images are not shown.

@fbunoz
Copy link
Contributor

fbunoz commented Nov 24, 2016

I verified that the images associations to an image have been migrated correctly.
I seems OK for https://api.demov6.camptocamp.org/images/208579 (which has an association to image 188564)
but not for https://api.demov6.camptocamp.org/images/188564 (which hasn't any image association)
Maybe only parent associations are shown in the API ?

@tsauerwein
Copy link
Member

but not for https://api.demov6.camptocamp.org/images/188564 (which hasn't any image association)

What association to which document are you missing?

@fbunoz
Copy link
Contributor

fbunoz commented Nov 24, 2016

In https://api.demov6.camptocamp.org/images/188564, it misses the association to the image 208579, as they are associated each other, and there is no hierarchy in the image association.
But as the association to 188564 appears in 208579, it seems the association has been migrated correctly in the BD, and it would just be a problem in the API.

@tsauerwein
Copy link
Member

Thanks, I created an issue for the API: c2corg/v6_api#530

@asaunier
Copy link
Member Author

asaunier commented Nov 24, 2016

There is nothing in the image detail view template that would display the associated images (in an image carousel as for the other document types):

@cbeauchesne cbeauchesne transferred this issue from c2corg/v6_ui Apr 1, 2019
@cbeauchesne cbeauchesne added the imported from v6 Issue created on v6 repo label Apr 1, 2019
@cbeauchesne
Copy link
Member

There is two issues in one : API does not shows association A > B if association B > A exists. : c2corg/v6_api#530

And a gallery is missing if associations exists. Let's go with this : this issue will describe the UI part, and API issue will describe API part

@cbeauchesne cbeauchesne changed the title Images associated to each other Show associated images on image view Apr 1, 2019
@cbeauchesne cbeauchesne added the good first issue Good for newcomers label Apr 1, 2019
@cbeauchesne cbeauchesne added this to the v7.0.3 milestone Apr 4, 2019
cbeauchesne added a commit that referenced this issue Apr 4, 2019
Show associated images on image view #396
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers imported from v6 Issue created on v6 repo
Projects
None yet
Development

No branches or pull requests

5 participants