Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve or clarify the reportNum parameter #34

Open
yxngl opened this issue Dec 7, 2023 · 1 comment
Open

Improve or clarify the reportNum parameter #34

yxngl opened this issue Dec 7, 2023 · 1 comment
Assignees

Comments

@yxngl
Copy link
Collaborator

yxngl commented Dec 7, 2023

Currently because cluster representatives of redundancy reduction methods are always added to the top results shown in the webpage, the actual number of gene sets could exceed the reportNum threshold. Or the information will not be available when AP or WSC is chosen. Either we can store a separate list for them or figure out a better way since the redundancy reduction need some changes in the new version.

Another related problem is when representatives are rescued, they are just appended to the end without sorting again. This could be fixed quickly.

@iblacksand
Copy link
Collaborator

In the new package, users can enable and disable the redundancy removal, so the size of this effect will change depending on what they enable.

I'll fix this in my fork. I think not showing the representatives in the All table could be a nice middle ground. Although it may be confusing for new users when they see gene sets that are not found in the top $n$ list.

I mirrored this issue in my fork at iblacksand#7 and experiment with different options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants