Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

notebook 运行时需要检查该notebook 是否引用了不存在于该 notebook 的变量或临时表,并给出提示 #133

Open
ZhengshuaiPENG opened this issue Apr 2, 2022 · 3 comments
Assignees
Labels
Milestone

Comments

@ZhengshuaiPENG
Copy link
Contributor

ZhengshuaiPENG commented Apr 2, 2022

在一个notebook 里声明的变量或临时表,即使删除会一直存在在engine的 session里,在点击运行时需要做检查并给出提示。

复现步骤:

  1. 新建一个notebook
  2. 在 cell 中执行一个 select 语句,as output 临时表,执行后删除
  3. 重写一个 select 语句, from 上面定义的临时表,此时是可以继续执行的

解决方案1: 由于 notebook 中的临时表和变量是用户session级别的,所以需要在执行 notebook 的时候,检查该 notebook 是否引用了没有在该notebook 中显式声明的临时表,并给出 warning 提示
解决方案2: 增加 byzer-lang 的生命周期的级别,出一个 notebook 级别的 session, 避免 notebook 之间互相影响

@ZhengshuaiPENG
Copy link
Contributor Author

可以参考文章 https://zhuanlan.zhihu.com/p/491545059

@ZhengshuaiPENG
Copy link
Contributor Author

ZhengshuaiPENG commented Apr 11, 2022

出 BIP 并 fix, 4d(后端 3.5,前端 0.5)

@ZhengshuaiPENG
Copy link
Contributor Author

ZhengshuaiPENG commented Apr 13, 2022

经过讨论,此issue 将拆分成两个issue

  1. 设计多级 session 机制 (per request, per namespace, per user)增加变量的 session 级别 byzer-lang#1747
  2. 实现 list 变量以及 del 变量 ,管理issue 支持 list 临时变量以及 del 临时变量 byzer-lang#1746

@ZhengshuaiPENG ZhengshuaiPENG modified the milestones: Sprint-04/22, Backlog Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants