Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DateOnly in Netstandard2.1 #117

Open
emitrackman opened this issue Nov 15, 2024 · 0 comments
Open

DateOnly in Netstandard2.1 #117

emitrackman opened this issue Nov 15, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@emitrackman
Copy link

Describe the bug

Generated code contains references to DateOnly which is not supported by netstandard2.1 and thus can't be used in Unity
Compilation fails with
ZeroQL/config.zeroql.json.g.cs(11736,404): error CS0246: The type or namespace name 'DateOnly' could not be found (are you missing a using directive or an assembly reference?)

How to Reproduce

Follow instructions from here:
https://github.com/byme8/ZeroQL/wiki/Unity-setup

Expected behavior

It compiles.

The GraphqQL schema that fails

Any schema that has Date in it will do.

Environment (please complete the following information):

  • Nuget package version [6.2.1]
  • IDE: none, CLI
  • .Net Version : [NetStandard2.1, Unity]

Additional information

I noticed before ZeroQL was using DateTime so it's probably this change broke it
bc83141

maybe we can shield it with #if !NETSTANDARD and use DateTime instead of DateOnly there.

@emitrackman emitrackman added the bug Something isn't working label Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant