Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] Needs support background color for both dark mode and light mode #12

Open
medopaw opened this issue May 25, 2022 · 1 comment
Open

[Feature Request] Needs support background color for both dark mode and light mode #12

medopaw opened this issue May 25, 2022 · 1 comment

Comments

@medopaw
Copy link

medopaw commented May 25, 2022

I suggest adding two settings: blockhighlight.lightBackground and blockhighlight.darkBackground.

If light theme is used, we check blockhighlight.lightBackground and then blockhighlight.background.

If dark theme is used, we check blockhighlight.darkBackground and then blockhighlight.background.
@medopaw medopaw changed the title Needs support background color for both dark mode and light mode [Feature Request] Needs support background color for both dark mode and light mode May 25, 2022
@medopaw
Copy link
Author

medopaw commented May 25, 2022

I guess we also need blockhighlight.highContrastBackground and blockhighlight.highContrastLightBackground.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@medopaw