Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement SailsQuery object to represent BLUEPRINT methods #37

Open
burntblark opened this issue Nov 10, 2018 · 0 comments
Open

Implement SailsQuery object to represent BLUEPRINT methods #37

burntblark opened this issue Nov 10, 2018 · 0 comments

Comments

@burntblark
Copy link
Owner

BLUEPRINT methods that are allowed through routes should be ready to use. https://sailsjs.com/documentation/concepts/blueprints/blueprint-routes

So I think using the same names https://sailsjs.com/documentation/reference/blueprint-api
it would be nice Because as LIB is for Sails I think it should follow the same nomenclature.

I say this because there are some methods like SAVE

public save(model: T): Observable<T> {

REMOVE Which in the case I believe should be called destroy.
Because the remove in BLUEPRINT is used for something else

public remove(id: string): Observable<T> {

AND findById that does not meet any Waterline or blueprint nomenclature.

public findById(id: string): Observable<T> {

Originally posted by @abalad in #35 (comment)

@burntblark burntblark changed the title Implement SailsQuery object to represent BLUEPRINT methods Implement SailsQuery object to represent BLUEPRINT methods Nov 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant