Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

localstorage access issues on chrome: is missing error handling #2

Open
jellegerbrandy opened this issue Feb 5, 2020 · 3 comments
Open

Comments

@jellegerbrandy
Copy link

On chrome, with local storage nuked (i.e.empty local storage), I get the following error when visiting https://web3connect.com/

image

There are two problems here:

  • The error above
  • The fact that the error is not caught, and so the website simply logs it but does (and cannot easily) show an error message. (web3connecxt.com simply shows nothing at all). Trying to connect on https://alchemy-competition-xdai.herokuapp.com/ hangs on “fetching your wallets”, with the same error
@jellegerbrandy
Copy link
Author

The reason I see this error in chrome is because I ahve "block third-party cookies" disabled on Chrome.

Again, this error needs to be caught with a meaningful error message.

@dmihal
Copy link
Contributor

dmihal commented Feb 6, 2020

The new version of @burner-wallet/burner-connect-provider (0.1.1) should handle this issue (and #5), errors are handled gracefully and displayed to the user.

@jellegerbrandy
Copy link
Author

Ok, we get an error message from the burner wallet now, which is much better.

However, we may want to handle such errors ourselves. I.e. what happens now is:

  • open the web3 connct modal
  • try to connect to burner wallet
  • see the error message from the burner wallet (your browser does not support...)
  • close the dialog
  • web3connect throws an "unknown error"
  • alchemy shows this error to the user

I'd say that

(a) the error should be propagated anyway, i.e. after closing the burnerconnect error dialog, you should still throw a more specific error (which we can handle, maybe with instructions to fix if applicable)
(b) [optional] an option to not show the burnerwallet error dialog at all (bc we have our own notifications)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants