-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AsyncAPI Cheatsheet feedback #310
Comments
Hey @derberg, Thanks for your warm feedback, it really helps! We updated the cheatsheet just moments before your message, reworking the $ref and some other small typos. You can find it here We totally agree about the protocols: we had to choose one, but as you say, some parts of the specification are specific to one protocol or another. Now that there's a global v1, we are considering creating specific cheatsheets for the different protocols. Regarding custom extensions, it was both a space limit and the desire to focus on what are really the fundamentals of writing a good AsyncAPI definition for the V1 of the cheatsheet. Have a good day, and thanks again! 🙏 |
no worries, just one thing, in Specification is very conservative in this area:
|
Thanks a lot, we updated it with this feedback as well! |
First of all huge thanks for the work you did for the community and for sharing the knowledge about AsyncAPI with others at conferences. AsyncAPI Conference room was full of cheat sheet posters 😄
Let me pay back with some feedback about cheat sheet.
As a typical Polish guy, I will focus on possible improvements only 😆 . With some of you I already shared the positive feedback on how I like how you managed to represent complex info on a single page cheat sheet - we failed in this field with AsyncAPI cheatsheet we worked on before.
Operations
section, the$ref
for example message. It is#/messages/userData
but there is no root levelmessages
object. You need to point to specific message (you don't have to, in the end it is optional) under the channel you reference. Correct value should be#/channels/userSignedUp/messages/userSignedUp
(of course if you want to somehow relate to data fromChannels
section$ref
for channel has error as well, should be#/channels/userSignedUp
General Information
I think it is useful to add some simple comment to theservers
section. Explain that it is quite different in the case of AsyncAPI, compared to OpenAPI. In the case of websocket, the server might point to the service address, but in other architectures, with other protocols,server
can be a broker detail. Not many people realize that. In the cheat sheet that we did, we have diagram that address pub/sub model, so we use that to explain to people, in your case you need at least a sentence in my opinionSo as you can see, some minor suggestions to amazing work you did!
The text was updated successfully, but these errors were encountered: