overlay: keep comments and linewidth when dumping to YAML #593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the original file is YAML and the target overlayed definition is YAML, we now preserve comments from the original document and also keep the same line width as the original file.
paulRbr
force-pushed
the
keep-comments-and-line-width
branch
from
d452464 to
e35e813
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the original file is YAML and the target overlayed definition is
YAML, we now preserve comments from the original document and also
keep the same line width as the original file.
Superseeds #581 (thanks a lot @thim81 for your contribution 🙏)
Closes #579