-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplifying base templates #73
base: 2.x
Are you sure you want to change the base?
Conversation
@seanmcn It seems that everything is fine here, before the release of the 2.x version it is better to apply these changes.. But it’s better to check it first, can you please do this? :) |
One thing that's a bit strange to me, and this is probably more to do with the 2.x.x branch than this PR is now if I run:
I get:
Do I need to pass this in manually now or? |
@seanmcn For some reason I can't reply to the thread. The error in php demo/demo1/demoScript.php occurs because the demo config has not been corrected, it just needs to be corrected and the necessary option added |
What type of PR is this? (check all applicable)
Description
Checklist before requesting a review