Not logging click on button

[faqndo97]

Video example:

Screen.Recording.2022-04-23.at.6.15.00.PM.mov

So the problem is that I have a button to only open a modal, and that action is not logged to port into the spec. That button doesn't have value attribute and the property text seems to not exist for buttons, and instead we should use textContent. So I tried all the cases for this code:

magic_test/app/views/magic_test/_javascript_helpers.html

Lines 15 to 21 in 1c44e38

	if (tagName == "BUTTON" || tagName == "A" || (tagName == "INPUT" && element.type == 'submit')) {
	action = "click_on"
	target = element.value || element.text
	if (!target) {
	return;
	}
	target = "\'" + target.trim().replace("'", "\\\'") + "\'"

Link

Submit input

Button

And seems that the textContent is a better option instead of text that will work in the three scenarios.

What do you think?

I can help to tackle this if needed.