-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add remote ssh port as configuration parameter #241
Comments
Not sure what the use case there is. Multiple ports on the remote machine? |
Well, not everyone maintains |
I would still suggest to configure SSH for this. Then the configuration can be applied not only to MF. Using a remote machine still involves using SSH from time to time — to clear caches, kill processes, test excutables. We even mention using SSH to test the connection before configuring MF in the first place. |
The reason why I want to allow configuring these things on Mainframer side (including cli params), is to make Mainframer more friendly for automation in different environments, including CI or scripts, etc where configuring |
That’s understandable for sure, but at the same time it either means password-based auth and no performance improvements like |
Before I forgot. There is a middleground. We can provide an option to create SSH key and put everything in |
That's not true, default ssh key (
True, prob not very important for automation setups and is configurable anyway if they want.
Definitely not going to do that lol, that's a lot of work and potentially a security issue if we do it wrong. We can hide SSH as implementation detail or embrace it, so far you (and I) have done the latter and it's just me bothering with some comments on your PRs to make |
Right now we fully rely on
~/.ssh/config
implicitly processed byssh
and the fact that default port is22
, adding it on our config level will allow project-specific overrides as part of #213.The text was updated successfully, but these errors were encountered: