Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Locust GitHub Action should create summary against merged commit #31

Open
zomglings opened this issue Oct 28, 2020 · 0 comments
Open

Locust GitHub Action should create summary against merged commit #31

zomglings opened this issue Oct 28, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@zomglings
Copy link
Member

GitHub's PR UI shows the diff of the base branch with a ref in which the base branch has been merged into the head branch.

Locust summaries take the diff of the base branch with the head branch directly.

When the base branch contains changes not in the head branch, the Locust summary shows different modifications than the GitHub diff.

When the Locust summary is generated for GitHub, Locust should:

  1. Try to merge the base branch into the head branch. If this succeeds, set base=base, head=base->head
  2. If this merge fails, fall back to base=base, head=head
  3. Take diff of base with head.
  4. Run Locust summary generator, but replace all links to files with links to diffs (i.e. PR comments).

This last change should probably get its own issue, as it's a substantial improvement in the user experience, and seems like a significant chunk of work.

@zomglings zomglings added the enhancement New feature or request label Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant