Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dialogs are not imported by default #689

Open
whitebyte opened this issue Oct 26, 2024 · 2 comments
Open

Dialogs are not imported by default #689

whitebyte opened this issue Oct 26, 2024 · 2 comments

Comments

@whitebyte
Copy link
Contributor

import dlangui;

// without this two lines Dialog and FileDialog are undefined identifiers, but other widgets works just fine
// import dlangui.dialogs.dialog;
// import dlangui.dialogs.filedlg;

...

FileDialog dlg = new FileDialog(caption, window, null); // error if two dialogs are not imported explicitly
@whitebyte whitebyte changed the title Dialogs are not imported Dialogs are not imported by default Oct 26, 2024
@GrimMaple
Copy link
Collaborator

I think I'm against public imports, but feel free to submit a PR, I'll merge it

@whitebyte
Copy link
Contributor Author

I don't think I'm opening a PR against maintainer's will. I don't have a strong opinion on public imports, what actually bothers me here is http://buggins.github.io/dlangui/ddox/dlangui.html
Some things are imported by default while others are not, and it's not clear what exatly import dlangui imports. "most useful DLANGUI modules" is pretty vague

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants