Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(store): Not change store reference on every UPDATE_ACTION #150

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(store): Not change store reference on every UPDATE_ACTION #150

wants to merge 1 commit into from

Conversation

Jonnyprof
Copy link

@Jonnyprof Jonnyprof commented Apr 18, 2020 •
edited
Loading

Fixes #128

@rafa-suagu
Copy link

@btroncone @BBlackwo @bufke can you check this PR please? We've tested in our three apps and works like a charm.

@BBlackwo
Copy link
Collaborator

@Jonnyprof thanks for the PR. I've tested your code with my fork of your original project. But I'm getting the same issue where

You can see on console that "receiving global data" is printed 3 times:

So it seems this code doesn't fix your issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rehydratation changes all store references on UPDATE_ACTION
3 participants
@Jonnyprof @rafa-suagu @BBlackwo