Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to use Angular CLI, prettier, create demo app, add e2e tests #169

Open
2 of 7 tasks
BBlackwo opened this issue Sep 5, 2020 · 6 comments
Open
2 of 7 tasks
Labels
build Related to the build/CI help wanted

Comments

@BBlackwo
Copy link
Collaborator

BBlackwo commented Sep 5, 2020

The following would improve this repo a lot:

  • Change the build to use Angular CLI
  • Swap out TSLint for ESLint
  • Add prettier using prettier-schematic
    • Make sure that lint-staged runs prettier and ESLint
    • Consider changing formatting to 2 spaces (instead of 4) as that is the default
  • Replace protractor with cypress (using cypress-schematic)
  • Add a demo app consuming the library and add some e2e tests
@BBlackwo BBlackwo added build Related to the build/CI help wanted labels Sep 5, 2020
@BBlackwo BBlackwo changed the title Change to use Angular CLI and create demo app Change to use Angular CLI, create demo app, add e2e tests Sep 5, 2020
@BBlackwo
Copy link
Collaborator Author

BBlackwo commented May 20, 2021

#186 partially completes this:

  • Change the build to use Angular CLI
  • Swap out TSLint for ESLint

@sheikalthaf
Copy link

sheikalthaf commented Nov 8, 2021

@BBlackwo Anyone working on remaining changes? I'm ready to work on remaining changes.

Please let me know if I can work on this.

Thanks for these library

@BBlackwo
Copy link
Collaborator Author

BBlackwo commented Nov 8, 2021

Hi Sheik @sheikalthaf,

Would love to have you work on the remaining changes! Let me know if you have any questions or need help.

@sheikalthaf
Copy link

@BBlackwo thanks for the confirmation. Will work on it.

@BBlackwo
Copy link
Collaborator Author

BBlackwo commented Nov 8, 2021

For setting up Prettier my preference is to use the default options and not even have a config file.

@sheikalthaf
Copy link

@BBlackwo sure will do that 👍🏻

@BBlackwo BBlackwo changed the title Change to use Angular CLI, create demo app, add e2e tests Change to use Angular CLI, prettier, create demo app, add e2e tests May 24, 2023
@BBlackwo BBlackwo mentioned this issue May 24, 2023
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Related to the build/CI help wanted
Projects
None yet
Development

No branches or pull requests

2 participants