Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partial payment not being recognized by either WooCommerce or BTCPay #16

Open
ksdhans opened this issue May 16, 2023 · 1 comment
Open
Labels
enhancement New feature or request

Comments

@ksdhans
Copy link

ksdhans commented May 16, 2023

I've ended up with a partially paid invoice (the person paid less than half). WooCommerce doesn't show the partial payment. When I click on the pay button it creates a new BTCPay which doesn't recognize the previously paid amount (which is in an older BTCPay invoice).

The original payment is from 20 days ago, so the customer obviously gave up.

Is something misconfigured? Or is this a bug?

@ndeet
Copy link
Collaborator

ndeet commented Jun 27, 2023

Hey sorry for the late reply, missed the notifications like always ...

You are right that use case is not covered. Partial payments are only tracked on the current invoice but if the customer tries to pay again after the partial invoice expired it will create a new invoice and the old one would not be taken into account in that case. You should still see the partial payment in the orders custom fields
image

So far nobody had that case it seems (or they worked around it by customer directly contacting them) but yes this case is not covered properly. It is a bit tricky though and would require breaking changes, meaning a new major release as I would need to change the custom field data structure and maybe some rely on the current structure for accounting.

Note to self what needs to be done:

  • track multiple invoices
  • not only track multiple paymens, but track multiple payments by invoice id
  • keep additionally track of fiat amounts as we have different exchange rates on different invoices

@ndeet ndeet added the enhancement New feature or request label Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants