Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Critical bug fixes #2

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Critical bug fixes #2

wants to merge 3 commits into from

Conversation

nicfit
Copy link

@nicfit nicfit commented Mar 8, 2018

  1. Import from_json to fix SockBase.recv
  2. Fix args for moderate_set_role
  3. Raise exceptions for HTTP errors.
  4. Raise InvalidLogin for HTTP 403

1) Imoport from_json to fix SockBase.recv
2) Fix args for moderate_set_role
3) Raise exceptions for HTTP errors.
4) Raise InvalidLogin for HTTP 403
@nicfit nicfit mentioned this pull request Mar 8, 2018
@nicfit
Copy link
Author

nicfit commented Mar 14, 2018

This good for a first drop @bryant ? After this is in I'll make more PRs for the other stuff in #1

@DanielDublin
Copy link

DanielDublin commented May 12, 2018

@nicfit trying use the _get method in base.py doesnt work for me.
I'm trying to get all the info about the banned users, a playlist by id and they all fail.

@nicfit
Copy link
Author

nicfit commented May 13, 2018

All the test are passing on this branch for me. What can I run to reproduce?

plugdj.tests.test_join_room ... ok
plugdj.tests.test_chat ... ok
plugdj.tests.test_send_nonstring_chat ... ok
plugdj.tests.test_really_long_chat ... ok
plugdj.tests.test_user_info ... ok
plugdj.tests.test_fail_login ... ok
plugdj.tests.test_get_room_state ... ok

----------------------------------------------------------------------
Ran 7 tests in 2.719s

OK
_________________________________________________________ summary __________________________________________________________
  py27: commands succeeded
  congratulations :)

@DanielDublin
Copy link

DanielDublin commented May 14, 2018

I tried to run in my Bot.py
self.plug._get("bans")
Also 'self.plug._get("bans", jason = {slug:'room_name')'
And it ended up with errors.
Basically attempting to recieve a json file containing the ban info of all the banned users

@nicfit
Copy link
Author

nicfit commented May 15, 2018

What are the errors? I just added a _get("bans") test to this PR. This sounds environmental.

@DanielDublin
Copy link

This is odd, i havent touched it for over 24 hours and yet now it seems to be working.
It said last time that a value was missing or something. Strange.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants