-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Critical bug fixes #2
base: master
Are you sure you want to change the base?
Conversation
nicfit
commented
Mar 8, 2018
•
edited
Loading
edited
- Import from_json to fix SockBase.recv
- Fix args for moderate_set_role
- Raise exceptions for HTTP errors.
- Raise InvalidLogin for HTTP 403
1) Imoport from_json to fix SockBase.recv 2) Fix args for moderate_set_role 3) Raise exceptions for HTTP errors. 4) Raise InvalidLogin for HTTP 403
@nicfit trying use the _get method in base.py doesnt work for me. |
All the test are passing on this branch for me. What can I run to reproduce?
|
I tried to run in my Bot.py |
What are the errors? I just added a _get("bans") test to this PR. This sounds environmental. |
This is odd, i havent touched it for over 24 hours and yet now it seems to be working. |