-
Notifications
You must be signed in to change notification settings - Fork 663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Getting black overlay screen on every click #383
Comments
I think you got hit with the latest WordPress update. It looks like Swipebox is not compatible with the version of jQuery included in this. This may be an issue with Swipebox, or it may be an issue with the jQuery code that WP includes (WP does some modifications to the jQuery library to make it play nicely with the rest of its ecosystem). |
Yes its related to Swipebox and jQuery updates - done in WP 5.6: |
OK, I had to dig around a bit and I think I found the problem. The issue is that Swipebox relies on $.selector, which was removed in jQuery 3.0 (https://api.jquery.com/selector/). To fix this, you will have to modify some Swipebox code, and some code at your end: Firstly, if you are calling Now, for the Swipebox edits, firstly, you have this at the bottom of the swipebox.js (https://github.com/brutaldesign/swipebox/blob/master/src/js/jquery.swipebox.js):
You will change this to accept the additional parameter. This becomes:
Now, you will have to modify some lines near the top of the file:
... becomes:
And:
... becomes:
This works for me. Hopefully the author of Swipebox can merge this into the master. |
there is a fork that has it patched: https://github.com/mho79/swipebox/ |
@sayontan - thanks for sharing this. Superstar. |
Hi, @sayontan & @netzgestaltung I am having the same problem. But my English is not very good. I would be very happy if you could send a video about the solution to the problem. mail: [email protected] thx for all!!!!! |
Important! I solved the problem by installing the jQuery Migrate plugin. I am waiting for your help @sayontan @netzgestaltung |
Hi @gorkemtunali i don't do videos at all, whats your preferred Language? |
Thanks for the solution worked. 👍 |
Thanks for the solution @sayontan |
Hi @joshbounds you can either implement @sayontan s changes to that file or replace it with that forked one: https://github.com/mho79/swipebox/ |
you can also contact me over my page https://www.netzgestaltung.at/impressum/ for direct support. |
Thanks bro @sayontan |
Thanks for sharing, I think this is the best solution. I will update the repo soon. Happy new year everyone |
That's great @brutaldesign . |
Hi, for me the most simple way was, just like @gorkemtunali says:
|
it works for me, thanks :) |
Yes Also Worked for Me. Thanks You |
@brutaldesign So was this fix implemented in your codebase? Please advice |
@handfulofcats It's not clear to me if the codebase includes the update, but @sciueps' comment was 12 days ago, so I'm guessing not (e.g. there have been no commits since 12 days ago). |
@themightymo I updated the js files with the latest that's available on this repo and the issue was solved for me. Mind you, it could be that we're experiencing similar but different issues. |
Can someone please explain this further? I was able to find and replace the rest of the code but cannot find this anywhere. "This edit is in your code" isn't exactly descriptive. I've tried the Enable JQuerry Migration plug-in and the site loads, when signed in, but no errors are logged and nothing is automatically fixed. |
@sweatherholt23, Just confirming re: jQuery Migrate plugin - Did you configure the plugin to load the "legacy" version of jQuery? If you didn't do that in the plugin settings, then the jQuery Migrate plugin does nothing. |
Sorry - tried the plug-in again and it is working. |
I got the same problem and downgrade the WP version to WP 5.5.5 and it works perfectly. |
tried updating the js file, didnt work idk y , then tried the plugin , works thank you sm |
Thank you for the solutions! |
This worked for me as well, thanks! @gorkemtunali @sciueps |
This worked for me. Thank you! |
I have at least 2 sites that use your script that were experiencing the same issue today: a black overlay on every single click on every page. See https://digitaldirectoryexpress-com-2020-12-09.mystagingwebsite.com/directories/ for an example. The div that is covering everything is:
<div id="swipebox-overlay" style="width: 1346px; height: 983px;"><div id="swipebox-container"><div id="swipebox-slider" style="transform: translate3d(100%, 0px, 0px); display: block;"></div><div id="swipebox-top-bar" style="display: none;" class=""><div id="swipebox-title"></div></div><div id="swipebox-bottom-bar" style="display: none;" class=""><div id="swipebox-arrows"><a id="swipebox-prev" style="background-image: url("https://digitaldirectoryexpress-com-2020-12-09.mystagingwebsite.com/wp-content/themes/alivepromo/lib/images/swipebox/icons.svg");"></a><a id="swipebox-next" style="background-image: url("https://digitaldirectoryexpress-com-2020-12-09.mystagingwebsite.com/wp-content/themes/alivepromo/lib/images/swipebox/icons.svg");" class="disabled"></a></div></div><a id="swipebox-close" style="background-image: url("https://digitaldirectoryexpress-com-2020-12-09.mystagingwebsite.com/wp-content/themes/alivepromo/lib/images/swipebox/icons.svg");"></a></div></div>
Similar markup was in the overlay on the other site. Both sites use completely different themes, plugins, etc.
Any idea if this issue is related to Swipebox?
The text was updated successfully, but these errors were encountered: