Decouple PV from TranspositionTable

[brunocodutra]

Gauntlet

Dev

cutechess-cli -tournament gauntlet -games 2 -rounds 1500 -openings file=engines/openings-6ply-1000.pgn policy=round -concurrency 6 -ratinginterval 10 -resultformat wide -recover -engine conf=dev -engine conf=dumb-1.11 -engine conf=Nawito-22.07 -engine conf=Fridolin-4.0 -each option.Threads=2 option.Hash=32 tc=3+0.025

Rank Name                          Elo     +/-   Games    Wins  Losses   Draws   Points   Score    Draw 
   0 dev                           -21       5    9000    2174    2719    4107   4227.5   47.0%   45.6% 
   1 Nawito-22.07                   32       9    3000     953     674    1373   1639.5   54.6%   45.8% 
   2 Fridolin-4.0                   23       9    3000     887     687    1426   1600.0   53.3%   47.5% 
   3 dumb-1.11                       8       9    3000     879     813    1308   1533.0   51.1%   43.6%

Base

cutechess-cli -tournament gauntlet -games 2 -rounds 1500 -openings file=engines/openings-6ply-1000.pgn policy=round -concurrency 6 -ratinginterval 10 -resultformat wide -recover -engine conf=base -engine conf=dumb-1.11 -engine conf=Nawito-22.07 -engine conf=Fridolin-4.0 -each option.Threads=2 option.Hash=32 tc=3+0.025

Rank Name                          Elo     +/-   Games    Wins  Losses   Draws   Points   Score    Draw 
   0 base                          -18       5    9000    2251    2712    4037   4269.5   47.4%   44.9% 
   1 Nawito-22.07                   28       9    3000     962     720    1318   1621.0   54.0%   43.9% 
   2 Fridolin-4.0                   21       9    3000     893     713    1394   1590.0   53.0%   46.5% 
   3 dumb-1.11                       5       9    3000     857     818    1325   1519.5   50.6%   44.2%

STS1-STS15_LAN_v6.epd

python sts_rating.py -f "./epd/STS1-STS15_LAN_v6.epd" -e dev -t 8 --movetime 100 --maxpoint 100

STS Rating v14.2
Engine: chessboard
Hash: 32, Threads: 8, time/pos: 0.100s

Number of positions in ./epd/STS1-STS15_LAN_v6.epd: 1188
Max score = 1188 x 100 = 118800
Test duration: 00h:02m:00s
Expected time to finish: 00h:02m:34s

  STS ID   STS1   STS2   STS3   STS4   STS5   STS6   STS7   STS8   STS9  STS10  STS11  STS12  STS13  STS14  STS15    ALL
  NumPos     85     80     86     89     85     80     82     80     71     79     70     74     75     79     73   1188
 BestCnt     57     49     56     57     58     47     42     50     42     55     41     49     43     48     39    733
   Score   7187   6145   6935   7258   7490   7502   6073   6169   5794   6707   5853   6338   6010   6402   6194  98057
Score(%)   84.6   76.8   80.6   81.6   88.1   93.8   74.1   77.1   81.6   84.9   83.6   85.6   80.1   81.0   84.8   82.5

:: STS ID and Titles ::
STS 01: Undermining
STS 02: Open Files and Diagonals
STS 03: Knight Outposts
STS 04: Square Vacancy
STS 05: Bishop vs Knight
STS 06: Re-Capturing
STS 07: Offer of Simplification
STS 08: Advancement of f/g/h Pawns
STS 09: Advancement of a/b/c Pawns
STS 10: Simplification
STS 11: Activity of the King
STS 12: Center Control
STS 13: Pawn Play in the Center
STS 14: Queens and Rooks to the 7th rank
STS 15: Avoid Pointless Exchange

:: Top 5 STS with high result ::
1. STS 06, 93.8%, "Re-Capturing"
2. STS 05, 88.1%, "Bishop vs Knight"
3. STS 12, 85.6%, "Center Control"
4. STS 10, 84.9%, "Simplification"
5. STS 15, 84.8%, "Avoid Pointless Exchange"

:: Top 5 STS with low result ::
1. STS 07, 74.1%, "Offer of Simplification"
2. STS 02, 76.8%, "Open Files and Diagonals"
3. STS 08, 77.1%, "Advancement of f/g/h Pawns"
4. STS 13, 80.1%, "Pawn Play in the Center"
5. STS 03, 80.6%, "Knight Outposts"

[codecov]

Codecov Report

Patch coverage: 94.78% and project coverage change: -0.18% ⚠️

Comparison is base (7adca76) 79.08% compared to head (ccd9eb2) 78.91%.

❗ Current head ccd9eb2 differs from pull request most recent head 9decf57. Consider uploading reports for the commit 9decf57 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #500      +/-   ##
==========================================
- Coverage   79.08%   78.91%   -0.18%     
==========================================
  Files          43       43              
  Lines        1229     1257      +28     
==========================================
+ Hits          972      992      +20     
- Misses        257      265       +8     

Files Changed	Coverage Δ
lib/search/options.rs	100.00% <ø> (ø)
lib/search/pv.rs	81.39% <84.61%> (+14.72%)	⬆️
bin/engine.rs	77.27% <100.00%> (ø)
lib/search/line.rs	88.23% <100.00%> (-11.77%)	⬇️
lib/search/pvs.rs	93.54% <100.00%> (-0.21%)	⬇️
lib/search/transposition.rs	100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.