Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Constant "vesting start time" led to pre-vesting of new/re-allocated advisors' tokens #5

Open
kphed opened this issue Dec 1, 2023 · 1 comment
Assignees

Comments

@kphed
Copy link
Member

kphed commented Dec 1, 2023

The AdvisorVestingWallet.sol contract has its vesting start time defined as a constant variable (_VESTING_START) with the value of 1_698_768_000 (October 31, 2023 at 12:00pm EST). This value was unchanged when 3 advisor contracts were deployed today for Joey Santoro, Cogsy, and nap. This means that all 3 parties will have a portion of their advisor tokens vested from that time vs. vesting from the deployment time. Given the ongoing support Brrito has received from the 3 individuals, which started well before the vesting date, it is a mistake that I believe to be acceptable.

Going forward, future advisor tokens will start their vesting from the deployment block timestamp, and the contracts will be updated to reflect that rule shortly before the next advisor tokens are allocated.

@kphed kphed self-assigned this Dec 1, 2023
@kphed
Copy link
Member Author

kphed commented Dec 1, 2023

The issue was made for the sake of transparency and as a reminder to implement the changes mentioned above should we bring on any other advisors in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant