You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
Describe the bug
When you add a custom response filter using any of the methods (BrowserUpProxy#addResponseFilter, BrowserUpProxy#addFirstHttpFilterFactory, BrowserUpProxy#addLastHttpFilterFactory), Content-Encoding: gzip header does not appear in the HAR, despite the server sending it. In addition, Content-Length header also seems to get updated with the uncompressed size of the response. So it seems that the proxy decompresses the gzip response, and also removes the evidence of compression in the process.
Interestingly, this only seems to occur with gzip-compressed responses and not brotli. I believe that may be because BUP / BMP doesn't support brotli decompression yet.
Open any website that supports gzip compression (e.g., https://www.example.com - real site) through the proxy, with "Accept-Encoding: gzip" header added to the request. I used the proxy with Selenium and Chrome browser.
Save HAR and check the response headers. Content-Encoding header would be missing from the response. Similar request through curl or browser includes the header.
// save and analyze the HARHarhar = proxy.getHar();
Expected behavior
When a site supports gzip compression and Accept-Encoding header is sent with gzip value, server responds with Content-Encoding: gzip header and Content-Length header contains the compressed size. This information should be present in HAR as it was actually received.
Please complete the following information:
OS: macOS, Linux
Browser: Chrome
Version: 85
The text was updated successfully, but these errors were encountered:
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Describe the bug
When you add a custom response filter using any of the methods (
BrowserUpProxy#addResponseFilter
,BrowserUpProxy#addFirstHttpFilterFactory
,BrowserUpProxy#addLastHttpFilterFactory
),Content-Encoding: gzip
header does not appear in the HAR, despite the server sending it. In addition,Content-Length
header also seems to get updated with the uncompressed size of the response. So it seems that the proxy decompresses the gzip response, and also removes the evidence of compression in the process.Interestingly, this only seems to occur with gzip-compressed responses and not brotli. I believe that may be because BUP / BMP doesn't support brotli decompression yet.
To Reproduce
Steps to reproduce the behavior:
Content-Encoding
header would be missing from the response. Similar request through curl or browser includes the header.Expected behavior
When a site supports gzip compression and
Accept-Encoding
header is sent withgzip
value, server responds withContent-Encoding: gzip
header andContent-Length
header contains the compressed size. This information should be present in HAR as it was actually received.Please complete the following information:
The text was updated successfully, but these errors were encountered: