From c63c2e729d2cfc9a482828e3fa59132a40377852 Mon Sep 17 00:00:00 2001 From: Jelmer Date: Thu, 2 Dec 2021 11:24:06 +0000 Subject: [PATCH 1/2] Fix AVX2 detection on macOS Fix for https://github.com/marian-nmt/marian-dev/issues/880 but currently I'm especially interested in it from a TranslateLocally point of view. --- cmake/FindSSE.cmake | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/cmake/FindSSE.cmake b/cmake/FindSSE.cmake index 82ee7f3e0..31c4681d3 100644 --- a/cmake/FindSSE.cmake +++ b/cmake/FindSSE.cmake @@ -74,9 +74,7 @@ IF(CMAKE_SYSTEM_NAME MATCHES "Linux") ENDIF (AVX512_TRUE) ELSEIF(CMAKE_SYSTEM_NAME MATCHES "Darwin") - EXEC_PROGRAM("/usr/sbin/sysctl -n machdep.cpu.features" OUTPUT_VARIABLE - CPUINFO) - + EXEC_PROGRAM("/usr/sbin/sysctl -n machdep.cpu.features machdep.cpu.leaf7_features" OUTPUT_VARIABLE CPUINFO) STRING(REGEX REPLACE "^.*[^S](SSE2).*$" "\\1" SSE_THERE ${CPUINFO}) STRING(COMPARE EQUAL "SSE2" "${SSE_THERE}" SSE2_TRUE) IF (SSE2_TRUE) From 53fc98b9a2c93c9c1c8910010a8a93b38146b542 Mon Sep 17 00:00:00 2001 From: Roman Grundkiewicz Date: Thu, 2 Dec 2021 21:01:13 +0000 Subject: [PATCH 2/2] Update CHANGELOG.md --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 742e48200..ac58d3756 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -42,6 +42,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0. - Use target-agnostic matrix multiply interface for wasm builds and allow importing an implementation of this interface from separate wasm modules. ### Fixed +- Fix AVX2 detection on macOS - Segfault of spm_train when compiled with -DUSE_STATIC_LIBS=ON seems to have gone away with update to newer SentencePiece version. - Fix bug causing certain reductions into scalars to be 0 on the GPU backend. Removed unnecessary warp shuffle instructions. - Do not apply dropout in embeddings layers during inference with dropout-src/trg