Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORE-69: remove explicit dependency on snakeyaml #354

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

davidangb
Copy link
Contributor

Jira: https://broadworkbench.atlassian.net/browse/CORE-69

Removes the explicit dependency on snakeyaml. This supersedes #311.

When pulled in transitively, without the explicit dependency declaration, snakeyaml is at version 2.3:

Screenshot 2024-11-13 at 2 51 33 PM


  • Submitter: Make sure Swagger is updated if API changes
  • Submitter: If updating admin endpoints, also update firecloud-admin-cli
  • Submitter: Update FISMA documentation if changes to:
    • Authentication
    • Authorization
    • Encryption
    • Audit trails
  • Submitter: If you're adding new libraries, sign us up to security updates for them

@davidangb davidangb requested a review from a team as a code owner November 13, 2024 19:55
@davidangb davidangb requested review from calypsomatic, trholdridge, samanehsan and marctalbott and removed request for a team, calypsomatic and trholdridge November 13, 2024 19:55
Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.71%. Comparing base (31a75e6) to head (5364164).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #354   +/-   ##
========================================
  Coverage    59.71%   59.71%           
========================================
  Files           18       18           
  Lines          638      638           
  Branches        66       66           
========================================
  Hits           381      381           
  Misses         257      257           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davidangb davidangb merged commit 192bece into develop Nov 13, 2024
9 checks passed
@davidangb davidangb deleted the da_CORE-69_removeSnakeyaml branch November 13, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants