Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORE-69: scala steward config #353

Merged
merged 4 commits into from
Nov 13, 2024
Merged

Conversation

davidangb
Copy link
Contributor

@davidangb davidangb commented Nov 13, 2024

Jira: https://broadworkbench.atlassian.net/browse/CORE-69

Updates the Scala Steward config file. Note that the current config has a mistake and is not currently in use. For instance, see #349 and notice the "Note that the Scala Steward config file .scala-steward.conf wasn't parsed correctly" message in the PR description.

Changes to config:

  • limit to 5 PRs per Scala Steward run
  • move to "on-conflicts" mode for updating PRs
  • prefix PR titles with "CORE-69:"
  • fix the cron expression. This is the part that was causing parsing to fail. Since parsing was failing, Scala Steward was defaulting to "@asap" and I am changing that to weekly.
  • add grouping of minor/patch updates
  • add labels

  • Submitter: Make sure Swagger is updated if API changes
  • Submitter: If updating admin endpoints, also update firecloud-admin-cli
  • Submitter: Update FISMA documentation if changes to:
    • Authentication
    • Authorization
    • Encryption
    • Audit trails
  • Submitter: If you're adding new libraries, sign us up to security updates for them

@davidangb davidangb requested a review from a team as a code owner November 13, 2024 16:38
@davidangb davidangb requested review from samanehsan and marctalbott and removed request for a team November 13, 2024 16:38
Copy link
Contributor

@marctalbott marctalbott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about batching the minor and patch updates too like we're doing in Rawls?

Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.71%. Comparing base (192bece) to head (a01ce5a).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #353   +/-   ##
========================================
  Coverage    59.71%   59.71%           
========================================
  Files           18       18           
  Lines          638      638           
  Branches        66       66           
========================================
  Hits           381      381           
  Misses         257      257           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davidangb
Copy link
Contributor Author

What do you think about batching the minor and patch updates too like we're doing in Rawls?

@marctalbott added in e048e83!

@davidangb davidangb merged commit 0453a95 into develop Nov 13, 2024
9 checks passed
@davidangb davidangb deleted the da_CORE-69_scalaStewardConfig branch November 13, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants