Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DDO-3863] Fix notification context for suspending users #652

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

jack-r-warren
Copy link
Contributor

I got my wires crossed with how to assemble the context here and tests didn't catch it. Updates tests and uses the right context.

Testing

Updated

Risk

Low

@jack-r-warren jack-r-warren requested a review from a team as a code owner September 3, 2024 14:26
Copy link

github-actions bot commented Sep 3, 2024

No API changes detected

@jack-r-warren jack-r-warren enabled auto-merge (squash) September 3, 2024 14:27
Copy link

github-actions bot commented Sep 3, 2024

Published image from fadb4bd (merge 05d1c1d):

us-central1-docker.pkg.dev/dsp-artifact-registry/sherlock/sherlock:v1.5.45-05d1c1d
us-central1-docker.pkg.dev/dsp-devops-super-prod/sherlock/sherlock:v1.5.45-05d1c1d

@jack-r-warren jack-r-warren merged commit f658825 into main Sep 3, 2024
17 checks passed
@jack-r-warren jack-r-warren deleted the DDO-3863-fix-notification-context branch September 3, 2024 14:34
Copy link

codecov bot commented Sep 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.92%. Comparing base (bf6eeab) to head (fadb4bd).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #652   +/-   ##
=======================================
  Coverage   68.92%   68.92%           
=======================================
  Files         283      283           
  Lines       12818    12818           
=======================================
  Hits         8835     8835           
  Misses       3083     3083           
  Partials      900      900           
Files with missing lines Coverage Δ
...bility_synchronization/suspend_role_assignments.go 63.15% <100.00%> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants