Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add v4 variant QC annotation HT creation and true positive VCF export #402
Add v4 variant QC annotation HT creation and true positive VCF export #402
Changes from all commits
0e21a3b
9efe468
77d7dff
a9a08f6
a2750eb
4340453
ff13cb4
23e4a6a
377e15b
da55076
865413d
0337487
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Conceptual question - why does this have to be the case? Why can't the true positives not include singletons?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just adding to clarify what we are making. Want to make two files (there is also an option for a 3rd, but we probably won't test it, so no reason to make it).
We use these as true positives in the variant QC training so that we can see what the features we use in the model look like on rare variants that we have high confidence in being real.
This if statement is just throwing an error because if you don't pick one of these you are just asking for an empty VCF
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A bit unclear abt code - does it not export the True Positive VCFs if this isn't passed? If so, may want to mention in params. If I'm just misreading it though, then nvm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
get_variant_qc_annotation_resources
is only getting the resources and not actually performing the exportThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah sorry, makes sense now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there ever a use case where either --transmitted-singletons and/or --sibling-singletons are passed but not --export-true-positives-vcfs ? Do they, or the PipelineStepResourceCollection named 'export_true_positive_vcfs', have any other function in the code or are read in elsewhere ?
If there isn't, you could just choose to export if either true positive types are passed - it would cut down on arguments but might be less user-friendly when passing argument.
Think the only code change would be changing line #668 to
if true_positive_type:
, but only if this is the case