Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First line of entries is not always capitalised #5

Open
harrylloyd-bl opened this issue Jan 19, 2024 · 1 comment
Open

First line of entries is not always capitalised #5

harrylloyd-bl opened this issue Jan 19, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@harrylloyd-bl
Copy link
Collaborator

Current behaviour: Some entries start with the final lines of the previous entry e.g. "Bought in April, 1866."

Expected behaviour: The first part of an entry in the catalogue is the title, and the first part of this is always capitalised. All entries should therefore start with a capitalised section. This should be done through the application of a regex that identifies specifically capital letters

@harrylloyd-bl harrylloyd-bl added the bug Something isn't working label Jan 19, 2024
@harrylloyd-bl
Copy link
Collaborator Author

Partially fixed by improving shelfmark detection in dc88316 & 7973758. Also added logic to recognise "Bought in" specifically, and reorder lines as a result 8d9e856

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant