feature: add all frontmatter data to search index #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Apologies for the absurdly late comment on this…I'm interested in the idea but I'm concerned it could mean the size of the generated search index is greatly increased if all frontmatter gets included. Maybe this is an opt-in feature? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
Because the
lunrsearch engine does not guarantee order. By passing along all frontmatter, you could sort your posts by something like "date" for example when you query for all your posts, you may want to sort by "date"Other key considered
"frontmatter"instead of "data", but "data" felt like it was more aligned withdocument.data