Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modal focus issues (with patch) #29

Open
sswam opened this issue Dec 14, 2017 · 1 comment
Open

modal focus issues (with patch) #29

sswam opened this issue Dec 14, 2017 · 1 comment

Comments

@sswam
Copy link

sswam commented Dec 14, 2017

jqModal.js_focus.diff.txt
I am putting these two issues together because my patch covers both.
I imagine you might want to rework it.

  1. focusFunc does not run at the right time for an ajax modal, should run after content is loaded.
  2. When pressing tab and shift-tab, focus does not stay strictly within the modal.

minor issue: The code is indented with a mixture of tabs (width 2) and spaces.

@sswam sswam changed the title modal focus issues modal focus issues (with patch) Dec 14, 2017
@sswam
Copy link
Author

sswam commented Dec 14, 2017

It's not perfect yet, there are potential issues with other tabbable and non-tabbable fields (<a> tag, tabindex=-1, etc.). It seems there are jQuery selectors :tabbable and :focusable which might help. https://api.jqueryui.com/tabbable-selector/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant