Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert custom sync url #43128

Closed
bridiver opened this issue Jan 6, 2025 · 0 comments · Fixed by brave/brave-core#27136
Closed

Revert custom sync url #43128

bridiver opened this issue Jan 6, 2025 · 0 comments · Fixed by brave/brave-core#27136
Assignees
@bridiver
Labels
OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA/No release-notes/exclude
Milestone
1.75.x - Beta

Comments

@bridiver
Copy link
Contributor

bridiver commented Jan 6, 2025

brave/brave-core#25484 did not have a security review and some concerns were flagged.
brave/brave-core#27054 is also being reverted because it was a fix for 25484, but we should not have hardcoded service urls in the repo
@bridiver bridiver self-assigned this Jan 6, 2025
@bridiver bridiver mentioned this issue Jan 6, 2025
Merged
24 tasks
@rebron rebron added the priority/P2 A bad problem. We might uplift this to the next planned release. label Jan 7, 2025
@rebron rebron added this to General Jan 7, 2025
@rebron rebron moved this to In progress in General Jan 7, 2025
@github-project-automation github-project-automation bot moved this from In progress to Completed in General Jan 8, 2025
@brave-builds brave-builds added this to the 1.75.x - Nightly milestone Jan 8, 2025
@bsclifton bsclifton mentioned this issue Jan 8, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bridiver bridiver

Labels
OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA/No release-notes/exclude
Projects
General
Status: Completed
Milestone
1.75.x - Beta
Development

Successfully merging a pull request may close this issue.

Revert custom sync url brave/brave-core
3 participants
@bridiver @rebron @brave-builds