Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fluent API for arbitrary grid motion with interferograms #40

Open
brandondube opened this issue Jul 31, 2021 · 0 comments
Open

Fluent API for arbitrary grid motion with interferograms #40

brandondube opened this issue Jul 31, 2021 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@brandondube
Copy link
Owner

The new interface for interferograms requires the user to explicitly pass the mask, and provides the x,y,r,t variables in class with the positional state. This makes it significantly easier to use offset masks. The geometry module includes shifted versions of most shapes, but it may be worthwhile to add a interf.shift((dx,dy)) or interf.shift(dx, dy=None) method to move the grid.

It would be most efficient not to shift the dense grid. Benchmarking would need to be done to see whether optimize_xy_separable, shifting the vectors, and regridding is faster than shifting the grid. If the grid has not yet been computed, then the initialization could be modified, which will be cheapest overall.

@brandondube brandondube added enhancement New feature or request good first issue Good for newcomers labels Jul 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant