Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump braintree_ios to 5.25.0 #448

Merged
merged 4 commits into from
Apr 11, 2024
Merged

Bump braintree_ios to 5.25.0 #448

merged 4 commits into from
Apr 11, 2024

Conversation

KunJeongPark
Copy link
Contributor

@KunJeongPark KunJeongPark commented Apr 11, 2024

Summary of changes

  • Modify Package.swift and Podspec files to point to BT iOS 5.25.0
  • Update CHANGELOG

Checklist

  • Added a changelog entry

Authors

List GitHub usernames for everyone who contributed to this pull request.

@KunJeongPark KunJeongPark requested a review from a team as a code owner April 11, 2024 15:08
@KunJeongPark KunJeongPark changed the title update podspec and Package.swift 5.25.0 Bump braintree_ios to 5.25.0 Apr 11, 2024
}
}
],
"version" : 2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we do some digging and just make sure there aren't any issues moving this to version 2?

Copy link
Contributor Author

@KunJeongPark KunJeongPark Apr 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's what I am looking up. They are also missing the "object" key that was there before.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

@KunJeongPark KunJeongPark Apr 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently, version 2 is not compatible with Swift versions prior to 5.6.
It is recommended by a few people here is to add Package.resolved to .gitignore file
It is also mentioned that we could "force" v1.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We want to leave it so that we are all using the same version as far as adding it to the .gitignore. Lets run a test on 15.0 which is our minimally supported Xcode version in the SDK. If that looks good we can apply this change as is.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SPMTest looks good with Xcode 15.0 pointing to this branch.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for triple checking! ❤️

"version": 1
}
],
"version" : 2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same question here on just triple checking this won't causes issues moving from v1 to v2

@KunJeongPark KunJeongPark merged commit 98bea97 into main Apr 11, 2024
4 of 5 checks passed
@KunJeongPark KunJeongPark deleted the bump-core-5.25 branch April 11, 2024 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants