-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump braintree_ios
to 5.25.0
#448
Conversation
braintree_ios
to 5.25.0
} | ||
} | ||
], | ||
"version" : 2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we do some digging and just make sure there aren't any issues moving this to version 2?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that's what I am looking up. They are also missing the "object" key that was there before.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apparently, version 2 is not compatible with Swift versions prior to 5.6.
It is recommended by a few people here is to add Package.resolved to .gitignore file
It is also mentioned that we could "force" v1.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We want to leave it so that we are all using the same version as far as adding it to the .gitignore
. Lets run a test on 15.0 which is our minimally supported Xcode version in the SDK. If that looks good we can apply this change as is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SPMTest looks good with Xcode 15.0 pointing to this branch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for triple checking! ❤️
"version": 1 | ||
} | ||
], | ||
"version" : 2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same question here on just triple checking this won't causes issues moving from v1 to v2
Summary of changes
Checklist
Authors