Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Navigation Bar Bug #436

Merged
merged 3 commits into from
Dec 18, 2023
Merged

Fix Navigation Bar Bug #436

merged 3 commits into from
Dec 18, 2023

Conversation

jaxdesmarais
Copy link
Contributor

Summary of changes

  • Fix bug where setting global navigation bar overrides the payment selection screen (fixes Global Navigation Bar colors get applied in the DropIn #435)
  • Allow overriding navigation bar color and text via BTDropInUICustomization.barBackgroundColor and BTDropInUICustomization.primaryTextColor
    • This allows the payment selection screen to be customized in the same way as the other views

Checklist

  • Added a changelog entry

Authors

@jaxdesmarais jaxdesmarais requested a review from a team as a code owner December 11, 2023 21:55
@scannillo
Copy link
Contributor

Changes look good, not sure if this is worth the effort for adding a UI test?

@jaxdesmarais
Copy link
Contributor Author

Changes look good, not sure if this is worth the effort for adding a UI test?

Since are UI tests are still failing for unrelated reasons my thought was to 🏈 on it. It seems like most of the failing tests are hitting their timeout so it may also be a case of just bumping timeouts. 😢

@jaxdesmarais jaxdesmarais merged commit 503e48a into main Dec 18, 2023
4 of 5 checks passed
@jaxdesmarais jaxdesmarais deleted the fix-navigation-bar-bug branch December 18, 2023 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Global Navigation Bar colors get applied in the DropIn
3 participants