From 06a2da66ae31f4cc98643d7282d66581fde9eeb7 Mon Sep 17 00:00:00 2001
From: Ravindra Kele <ravindrak@bsf.io>
Date: Wed, 16 Oct 2024 21:10:05 +0530
Subject: [PATCH 1/3] alert button type change, and select text size change

---
 src/components/alert/alert.stories.js    |  4 ++--
 src/components/select/component-style.js | 10 +++++-----
 src/components/select/select.jsx         |  4 ++--
 3 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/src/components/alert/alert.stories.js b/src/components/alert/alert.stories.js
index be35cb53..a9576db9 100644
--- a/src/components/alert/alert.stories.js
+++ b/src/components/alert/alert.stories.js
@@ -170,7 +170,7 @@ export const WithAction = {
 		action: {
 			label: 'My Action',
 			onClick: () => {},
-			type: 'button',
+			type: 'link',
 		},
 	},
 };
@@ -183,7 +183,7 @@ export const WithCustomIcon = {
 		action: {
 			label: 'My Action',
 			onClick: () => {},
-			type: 'button',
+			type: 'link',
 		},
 	},
 };
diff --git a/src/components/select/component-style.js b/src/components/select/component-style.js
index 9a3708a3..1fed2348 100644
--- a/src/components/select/component-style.js
+++ b/src/components/select/component-style.js
@@ -3,15 +3,15 @@ export const sizeClassNames = {
 		icon: '[&>svg]:size-4',
 		searchIcon: '[&>svg]:size-4',
 		selectButton:
-			'px-2.5 py-2 rounded text-xs font-medium leading-4 min-h-[2rem]',
+			'px-2.5 py-2 rounded text-sm font-medium leading-4 min-h-[2rem]',
 		multiSelect: 'pl-2 pr-2 py-1.5',
-		displaySelected: 'text-xs font-normal',
+		displaySelected: 'text-sm font-normal',
 		dropdown: 'rounded-md',
 		dropdownItemsWrapper: 'p-1.5',
 		searchbarWrapper: 'p-3 flex items-center gap-0.5',
-		searchbar: 'font-medium text-xs',
+		searchbar: 'font-medium text-sm',
 		searchbarIcon: '[&>svg]:size-4',
-		label: 'text-xs font-medium',
+		label: 'text-sm font-medium',
 	},
 	md: {
 		icon: '[&>svg]:size-5',
@@ -33,7 +33,7 @@ export const sizeClassNames = {
 		selectButton:
 			'px-4 py-3 rounded-lg text-sm font-medium leading-5 min-h-[3rem]',
 		multiSelect: 'pl-2.5 pr-3 py-2.5',
-		displaySelected: 'text-sm font-normal',
+		displaySelected: 'text-base font-normal',
 		dropdown: 'rounded-lg',
 		dropdownItemsWrapper: 'p-2',
 		searchbarWrapper: 'p-2.5 flex items-center gap-1',
diff --git a/src/components/select/select.jsx b/src/components/select/select.jsx
index 24ecba36..94a3e24c 100644
--- a/src/components/select/select.jsx
+++ b/src/components/select/select.jsx
@@ -355,11 +355,11 @@ function SelectOptions( {
 						<div
 							ref={ refs.setFloating }
 							className={ cn(
-								'box-border [&_*]:box-border w-full bg-white outline-none shadow-lg outline outline-1 outline-border-subtle overflow-hidden',
+								'box-border [&_*]:box-border w-full bg-white outline-none shadow-lg outline outline-1 outline-border-subtle overflow-y-scroll',
 								combobox &&
 									'grid grid-cols-1 grid-rows-[auto_1fr] divide-y divide-x-0 divide-solid divide-border-subtle',
 								sizeClassNames[ sizeValue ].dropdown,
-								! combobox && 'h-full',
+								! combobox && 'h-auto',
 								className
 							) }
 							style={ {

From b6d6abee99f9fc1b58b03501c4183330d5512cd4 Mon Sep 17 00:00:00 2001
From: Ravindra Kele <ravindrak@bsf.io>
Date: Thu, 17 Oct 2024 11:05:19 +0530
Subject: [PATCH 2/3] font size

---
 src/components/select/select.jsx | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/components/select/select.jsx b/src/components/select/select.jsx
index 94a3e24c..035ee1c9 100644
--- a/src/components/select/select.jsx
+++ b/src/components/select/select.jsx
@@ -441,12 +441,12 @@ function SelectItem( { value, selected, children, className, ...props } ) {
 
 	const selectItemClassNames = {
 		sm: 'py-1.5 px-2 text-sm font-normal',
-		md: 'p-2 text-base font-normal',
+		md: 'p-2 text-sm font-normal',
 		lg: 'p-2 text-base font-normal',
 	};
 	const selectedIconClassName = {
 		sm: 'size-4',
-		md: 'size-5',
+		md: 'size-4',
 		lg: 'size-5',
 	};
 

From 17fb0c04cc4f9edf1ca46e2326b81922fd432016 Mon Sep 17 00:00:00 2001
From: Ravindra Kele <ravindrak@bsf.io>
Date: Thu, 17 Oct 2024 12:24:21 +0530
Subject: [PATCH 3/3] Scroll fix

---
 src/components/select/select.jsx | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/src/components/select/select.jsx b/src/components/select/select.jsx
index 035ee1c9..9540e26c 100644
--- a/src/components/select/select.jsx
+++ b/src/components/select/select.jsx
@@ -355,11 +355,14 @@ function SelectOptions( {
 						<div
 							ref={ refs.setFloating }
 							className={ cn(
-								'box-border [&_*]:box-border w-full bg-white outline-none shadow-lg outline outline-1 outline-border-subtle overflow-y-scroll',
+								'box-border [&_*]:box-border w-full bg-white outline-none shadow-lg outline outline-1 outline-border-subtle',
 								combobox &&
 									'grid grid-cols-1 grid-rows-[auto_1fr] divide-y divide-x-0 divide-solid divide-border-subtle',
 								sizeClassNames[ sizeValue ].dropdown,
 								! combobox && 'h-auto',
+								! combobox
+									? 'overflow-y-auto'
+									: 'overflow-hidden',
 								className
 							) }
 							style={ {