-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Theme.json font families to Astra custom fonts #65
Comments
I'll added weight range :
|
@xoex I realize this is an older ticket, but want to confirm that I am seeing custom fonts loaded in via a child theme's |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi. I'm using Astra and Custom fonts plugin. Inside my child theme, I added a theme.json file and added some typographies.
like this :
But astra doesn't automatically detect theme.json font families (at least for me), I wrote this code and i'm using it in child theme,
I think you can add this to astra theme or custom fonts plugin (as a setting, like to check to tickbox and theme.json font families will be added to astra custom fonts).
Of course code should be optimized, 1. fontfamily should be get from fontFace section, 2. fontWeight can be a range like "200 900". this code can't add them.
The text was updated successfully, but these errors were encountered: