Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Location: Street Address is adding one extra div #44

Open
metodiew opened this issue Jun 22, 2017 · 0 comments
Open

Location: Street Address is adding one extra div #44

metodiew opened this issue Jun 22, 2017 · 0 comments

Comments

@metodiew
Copy link

metodiew commented Jun 22, 2017

Hey guys,

We had an issue with one of our websites- when you a street name, you have an opening div https://github.com/brainstormforce/all-in-one-schemaorg-rich-snippets/blob/master/functions.php#L999, but if you don't fill the field, you have an extra closing </div> here https://github.com/brainstormforce/all-in-one-schemaorg-rich-snippets/blob/master/functions.php#L1009

I've fixed the issue, adding the same check if(trim($service_street) != "") for the closing </div> item, even if it doesn't WordPress Coding Standards, which seems to be working fine for the project I'm working on.

Would you check the submitted PR and see if there is anything else that needs to be fixed?

Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants