Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Use .brainglobe directory to store deformations #11

Open
PolarBean opened this issue Nov 8, 2024 · 10 comments
Open

[Feature] Use .brainglobe directory to store deformations #11

PolarBean opened this issue Nov 8, 2024 · 10 comments
Labels
enhancement New feature or request

Comments

@PolarBean
Copy link
Collaborator

would .brainglobe/deformations be a good directory from me to store the data @adamltyson?

@PolarBean PolarBean added the enhancement New feature or request label Nov 8, 2024
@PolarBean
Copy link
Collaborator Author

Alternatively I could store the deformation in the directory of the atlas, in the same folders as the atlas files. I'll review the v2 spec and start conforming to this

@adamltyson
Copy link
Member

brainglobe/deformations seems good to me. I would avoid adding to the atlas directories themselves, so we don't have to worry about overwriting them.

@PolarBean
Copy link
Collaborator Author

and for versioning is it best to add just a _v1.0 string to the end of filenames. This is what atlasapi does, is it something you want to continue doing?

@adamltyson
Copy link
Member

Yeah, for now. We can/should revisit once the API itself is updated.

add just a _v1.0 string

I assume you mean add the actual version, not just _v1.0!

@PolarBean
Copy link
Collaborator Author

well all the versions now will be v1.0! as it would just be versioning for the deformation matrix. But yeah in the future if the deformations are updated we would update the version number.

One issue is that there are versions of spaces and versions of deformations... This might get confusing

@adamltyson
Copy link
Member

Oh yeah, I misunderstood. Should a deformation version be a combination of space versions? I.e. a specific deformation version for specific versions of source and target spaces?

@PolarBean
Copy link
Collaborator Author

Yes I think so. But in addition you might want to improve a deformation so you would need to version that too. So there are three versions that need to be specified.
somthing like:
CCF_stpt_v1.3_to_Gubra_LSFM_v1.2_deformation_v2

@PolarBean
Copy link
Collaborator Author

but then again I assume the space won't update without changing it's name entirely??

@PolarBean
Copy link
Collaborator Author

if there was theoretically a ccfv4 based on MRI. would this still be allen_mouse in the brainglobe api

@adamltyson
Copy link
Member

if there was theoretically a ccfv4 based on MRI. would this still be allen_mouse in the brainglobe api

I guess it depends if the space changes, or just the reference image.

Realistically, all of this should/will change with atlas API V2, but that is likely to be some time off.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants