-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Use .brainglobe directory to store deformations #11
Comments
Alternatively I could store the deformation in the directory of the atlas, in the same folders as the atlas files. I'll review the v2 spec and start conforming to this |
|
and for versioning is it best to add just a _v1.0 string to the end of filenames. This is what atlasapi does, is it something you want to continue doing? |
Yeah, for now. We can/should revisit once the API itself is updated.
I assume you mean add the actual version, not just |
well all the versions now will be v1.0! as it would just be versioning for the deformation matrix. But yeah in the future if the deformations are updated we would update the version number. One issue is that there are versions of spaces and versions of deformations... This might get confusing |
Oh yeah, I misunderstood. Should a deformation version be a combination of space versions? I.e. a specific deformation version for specific versions of source and target spaces? |
Yes I think so. But in addition you might want to improve a deformation so you would need to version that too. So there are three versions that need to be specified. |
but then again I assume the space won't update without changing it's name entirely?? |
if there was theoretically a ccfv4 based on MRI. would this still be allen_mouse in the brainglobe api |
I guess it depends if the space changes, or just the reference image. Realistically, all of this should/will change with atlas API V2, but that is likely to be some time off. |
would .brainglobe/deformations be a good directory from me to store the data @adamltyson?
The text was updated successfully, but these errors were encountered: