Package manager support #335

ReallySnazzy · 2022-03-25T17:56:45Z

SirLynix · 2022-05-18T10:49:39Z

I added DPP to xmake repository (see xmake-io/xmake-repo#1222), with my changes it compiles fine on Windows, MinGW, Linux, macOS in both dynamic and static linking.

Since xmake is able to handle dependencies (will find libraries on the machine like cmake but is able to download and compile them if it doesn't find them), I managed to build the lib using a very short xmake.lua.

Usually, xmake packages use CMake to build CMake libraries, but the way dependencies are handled on DPP doesn't help much (mostly because they are embedded). Which is why I patched nlohmann/fmt out of the lib.

I also fixed the export.h header which made static linking impossible on Windows, here's the diff:

diff --git a/include/dpp/export.h b/include/dpp/export.h
index b7b35b5..838f79d 100644
--- a/include/dpp/export.h
+++ b/include/dpp/export.h
@@ -24,25 +24,29 @@
 // Investigate: MSVC doesn't like this
 //static_assert(__cplusplus >= 201703L, "D++ Requires a C++17 compatible compiler. Please ensure that you have enabled C++17 in your compiler flags.");
 
-#ifdef DPP_BUILD
+#ifndef DPP_STATIC
 
-	#ifdef _WIN32
-		#include <dpp/win32_safe_warnings.h>
-	#endif
+	#ifdef DPP_BUILD
+
+		#ifdef _WIN32
+			#include <dpp/win32_safe_warnings.h>
+		#endif
 
-	#ifdef _WIN32
-		#define DPP_EXPORT __declspec(dllexport)
+		#ifdef _WIN32
+			#define DPP_EXPORT __declspec(dllexport)
+		#else
+			#define DPP_EXPORT
+		#endif
 	#else
-		#define DPP_EXPORT
+		#ifdef _WIN32
+			#define DPP_EXPORT __declspec(dllimport)
+		#else
+			#define DPP_EXPORT
+		#endif
 	#endif
+
 #else
-	#ifdef _WIN32
-		#define DPP_EXPORT __declspec(dllimport)
-		/* This is required otherwise fmt::format requires additional file linkage to your project */
-		#define FMT_HEADER_ONLY
-	#else
-		#define DPP_EXPORT
-	#endif
+	#define DPP_EXPORT
 #endif
 
 #ifndef _WIN32

braindigitalis · 2022-05-18T11:21:32Z

nlohmann and fmt are header only. it would be nicer if they weren't patched out, because we test with specific versions and not just whatever the latest is which could cause support issues

SirLynix · 2022-05-18T11:24:24Z

xmake can be instructed to use a specific version of nlohmann/fmt.
The main issue here is that by embedding a specific version of those libraries (and not putting them in a namespace), you conflict with the user nlohmann/fmt libs (obligating them to use the very same version you're using for API/ABI compatibility).

Since these libraries are very well tested, I think it would be better to not embed them to prevent such issues.

braindigitalis · 2022-05-18T11:24:43Z

I added DPP to xmake repository (see xmake-io/xmake-repo#1222), with my changes it compiles fine on Windows, MinGW, Linux, macOS in both dynamic and static linking.

Since xmake is able to handle dependencies (will find libraries on the machine like cmake but is able to download and compile them if it doesn't find them), I managed to build the lib using a very short xmake.lua.

Usually, xmake packages use CMake to build CMake libraries, but the way dependencies are handled on DPP doesn't help much (mostly because they are embedded). Which is why I patched nlohmann/fmt out of the lib.

I also fixed the export.h header which made static linking impossible on Windows, here's the diff:
diff --git a/include/dpp/export.h b/include/dpp/export.h
index b7b35b5..838f79d 100644
--- a/include/dpp/export.h
+++ b/include/dpp/export.h
@@ -24,25 +24,29 @@
 // Investigate: MSVC doesn't like this
 //static_assert(__cplusplus >= 201703L, "D++ Requires a C++17 compatible compiler. Please ensure that you have enabled C++17 in your compiler flags.");
 
-#ifdef DPP_BUILD
+#ifndef DPP_STATIC
 
-	#ifdef _WIN32
-		#include <dpp/win32_safe_warnings.h>
-	#endif
+	#ifdef DPP_BUILD
+
+		#ifdef _WIN32
+			#include <dpp/win32_safe_warnings.h>
+		#endif
 
-	#ifdef _WIN32
-		#define DPP_EXPORT __declspec(dllexport)
+		#ifdef _WIN32
+			#define DPP_EXPORT __declspec(dllexport)
+		#else
+			#define DPP_EXPORT
+		#endif
 	#else
-		#define DPP_EXPORT
+		#ifdef _WIN32
+			#define DPP_EXPORT __declspec(dllimport)
+		#else
+			#define DPP_EXPORT
+		#endif
 	#endif
+
 #else
-	#ifdef _WIN32
-		#define DPP_EXPORT __declspec(dllimport)
-		/* This is required otherwise fmt::format requires additional file linkage to your project */
-		#define FMT_HEADER_ONLY
-	#else
-		#define DPP_EXPORT
-	#endif
+	#define DPP_EXPORT
 #endif
 
 #ifndef _WIN32

with this diff applied does dpp still build ok outside of xmake?
the FMT_HEADER_ONLY was there for a reason and otherwise it would build but fail at runtime...

SirLynix · 2022-05-18T11:28:31Z

with this diff applied does dpp still build ok outside of xmake?

Yes, but DPP_STATIC should be handled in the cmakelists.

the FMT_HEADER_ONLY was there for a reason and otherwise it would build but fail at runtime...

It makes little sense to build the lib without FMT_HEADER_ONLY and use it with user code, the reason it was failing was because fmt has to be linked to the final executable without that flag, something a proper package manager guarantees.

braindigitalis · 2022-05-18T11:28:33Z

xmake can be instructed to use a specific version of nlohmann/fmt. The main issue here is that by embedding a specific version of those libraries (and not putting them in a namespace), you conflict with the user nlohmann/fmt libs (obligating them to use the very same version you're using for API/ABI compatibility).

Since these libraries are very well tested, I think it would be better to not embed them to prevent such issues.

I see, I will consider moving dpp's copies to a namespace to prevent conflicts.

braindigitalis · 2022-05-18T11:29:48Z

with this diff applied does dpp still build ok outside of xmake?

Yes, but DPP_STATIC should be handled in the cmakelists.

the FMT_HEADER_ONLY was there for a reason and otherwise it would build but fail at runtime...

It makes little sense to build the lib without FMT_HEADER_ONLY and use it with user code, the reason it was failing was because fmt has to be linked to the final executable without that flag, something a proper package manager guarantees.

thanks! can you please submit a pr of this diff against dev branch and I'll merge it in...

SirLynix · 2022-05-18T11:36:54Z

I see, I will consider moving dpp's copies to a namespace to prevent conflicts.

Unfortunately this won't be enough, because of preprocessor defines (libs header guards), there's no proper way to embed fmt/nlohmann in a project headers.

thanks! can you please submit a pr of this diff against dev branch and I'll merge it in...

Someone else is working on this already, all my changes will only be applied when installing dpp through xmake.

If you wish to keep using CMake, xrepo-cmake may help you to handle dependencies in a better way.

M-U-X · 2022-06-23T18:50:19Z

Vcpkg support would be quite nice, is it coming anytime soon?

braindigitalis · 2022-06-23T21:09:44Z

there's an open pr over there, ive not had time to work on it though...

braindigitalis · 2022-07-24T21:11:43Z

Vcpkg support would be quite nice, is it coming anytime soon?

there is now a finalized pr in vcpkg thanks to @RealTimeChris - we should be in vcpkg very soon!

egorpugin · 2022-08-03T07:32:54Z

fyi
Added to SW https://software-network.org/org.sw.demo.brainboxdotcc.dpp-10.0.15

braindigitalis · 2022-08-03T08:04:42Z

Nice, thanks! does this auto update from github releases?

egorpugin · 2022-08-03T09:06:54Z

No, not yet.
Such feature is on todo list, but won't be here soon enough.

NexAdn · 2022-08-29T10:47:07Z

Since I have already an ebuild for Gentoo, I might as well move it to ::guru (the AUR equivalent for Gentoo). DPP is probably not big enough (in terms of consumers) for the main repo, but ::guru should suffice.

However, since I had to patch the installation for DPP to work on my Gentoo machines (mainly to correct some paths and file names), I might submit a PR making some changes to the installation procedure first.

braindigitalis · 2022-08-29T18:39:38Z

Since I have already an ebuild for Gentoo, I might as well move it to ::guru (the AUR equivalent for Gentoo). DPP is probably not big enough (in terms of consumers) for the main repo, but ::guru should suffice.

However, since I had to patch the installation for DPP to work on my Gentoo machines (mainly to correct some paths and file names), I might submit a PR making some changes to the installation procedure first.

thanks, i'd like to see this 😊

SirObby · 2022-12-03T18:24:43Z

Hey @NexAdn are you still going to move your ebuild for Gentoo to the GURU?
If not, would you mind if I do that?

thenameisluk · 2022-12-03T18:38:12Z

bruh

NexAdn · 2022-12-04T10:15:10Z

@SirObby oh boy, I totally forgot that 😓 Feel free to move your ebuild. If you want, we can co-maintain it (you can use [email protected] as my email for metadata.xml).

The previous method of installation didn't respect the standard dirs, leading to build tools not recognizing DPP correctly. This commit fixes this by moving everything to the standard dirs. As a side effect, files are no longer installed twice, due to CMake already placing some files in the right spots. Issue: brainboxdotcc#590 Issue: brainboxdotcc#335

NexAdn · 2023-01-04T13:35:34Z

The Gentoo package is now uploaded to GURU and should be available for the public soon. it is maintained by @SirObby and me

RatTrap1337 · 2023-01-25T17:58:23Z

add openssl to vcpkg on linux its not present

braindigitalis · 2023-01-25T18:01:32Z

add openssl to vcpkg on linux its not present

... who uses vcpkg on linux 😂
nah, PR welcome. vcpkg is broken right now, and needs redoing.

braindigitalis · 2023-09-24T15:03:41Z

Is there interest in having conan support?

of course, is this something you have experience with?

MikeRavenelle · 2023-09-24T16:02:55Z

Yes I do. I can look into writing a conan recipe.

mrtuxa · 2023-09-25T09:10:20Z

i guess the best opiton is to push it into nixpkgs

Jaskowicz1 · 2023-11-02T10:40:35Z

AUR needs a new maintainer. The current maintainer (@Eremiell) hasn't been around in a while. If anyone knows how to do this, that'd be great!

Jaskowicz1 · 2023-11-13T11:08:13Z

I'm looking at creating a brew package for silicone Mac processors (Darwin). It's currently in the works right now and I'll be back with more information soon.

Jaskowicz1 · 2023-11-13T21:45:46Z

Brew PR is up, ~~we have to wait til next release for it to go anywhere as currently our unit test is broken on Mac. I launched a PR to fix this though!~~

Edit: Even though a PR was launched to fix the unit tests on Mac, we are no longer required to wait for the unit test and we should expect brew to accept the PR soon.

Jaskowicz1 · 2023-11-28T15:43:59Z

We are now on Brew!! 🥳

razaqq · 2023-12-06T18:10:58Z

any update on conan support?

Jaskowicz1 · 2023-12-06T18:38:34Z

any update on conan support?

We've had a couple of people say they want to do it but we've not heard anything since, sadly. Is this something you know how to do?

MikeRavenelle · 2024-01-20T02:06:49Z

any update on conan support?

I have a PR that has a conan recipe. Some work is left to be done to finalize it as well as get it on the conan center.

AA1999 · 2024-01-23T21:19:45Z

any update on conan support?

We've had a couple of people say they want to do it but we've not heard anything since, sadly. Is this something you know how to do?

tbf Emirell and I were going to do it, however, at that point, Conan 2.0 was still not fully supported

Jaskowicz1 · 2024-05-24T07:47:23Z

No longer marked as stale

AA1999 · 2024-07-24T20:54:12Z

I can get working on conan if no one else has

Jaskowicz1 · 2024-07-24T20:55:49Z

I can get working on conan if no one else has

That would be wonderful! #1066 is the best place to pickup, there was some good progress made here.

github-actions · 2024-09-23T02:34:36Z

This issue has had no activity and is being marked as stale. If you still wish to continue with this issue please comment to reopen it.

braindigitalis · 2024-10-25T18:08:09Z

the next release should be available on Conan 😀

braindigitalis · 2024-10-30T14:20:40Z

we are now in Conan centre!

conan-io/conan-center-index#25745

ReallySnazzy added the project label Mar 25, 2022

braindigitalis added the help wanted Extra attention is needed label Mar 25, 2022

braindigitalis added the good first issue Good for newcomers label Jun 17, 2022

github-actions bot added the Stale label Oct 29, 2022

braindigitalis removed the Stale label Oct 29, 2022

brainboxdotcc deleted a comment from github-actions bot Oct 29, 2022

Jaskowicz1 pinned this issue Feb 19, 2024

github-actions bot added the Stale label Mar 24, 2024

braindigitalis removed the Stale label Mar 24, 2024

brainboxdotcc deleted a comment from github-actions bot Mar 24, 2024

github-actions bot added the Stale label May 24, 2024

brainboxdotcc deleted a comment from github-actions bot May 24, 2024

Jaskowicz1 removed the Stale label May 24, 2024

github-actions bot added the Stale label Jul 24, 2024

braindigitalis removed the Stale label Jul 24, 2024

brainboxdotcc deleted a comment from github-actions bot Jul 24, 2024

github-actions bot added the Stale label Sep 23, 2024

braindigitalis removed the Stale label Sep 23, 2024

braindigitalis linked a pull request Oct 25, 2024 that will close this issue

feat: conan 2.x recipe #1308

Merged

5 tasks

Package manager support #335

Package manager support #335

Comments

ReallySnazzy commented Mar 25, 2022 • edited by braindigitalis Loading

SirLynix commented May 18, 2022

braindigitalis commented May 18, 2022

SirLynix commented May 18, 2022

braindigitalis commented May 18, 2022

SirLynix commented May 18, 2022

braindigitalis commented May 18, 2022

braindigitalis commented May 18, 2022

SirLynix commented May 18, 2022 • edited Loading

M-U-X commented Jun 23, 2022

braindigitalis commented Jun 23, 2022

braindigitalis commented Jul 24, 2022

egorpugin commented Aug 3, 2022

braindigitalis commented Aug 3, 2022

egorpugin commented Aug 3, 2022

NexAdn commented Aug 29, 2022

braindigitalis commented Aug 29, 2022

SirObby commented Dec 3, 2022

thenameisluk commented Dec 3, 2022

NexAdn commented Dec 4, 2022

NexAdn commented Jan 4, 2023

RatTrap1337 commented Jan 25, 2023

braindigitalis commented Jan 25, 2023

braindigitalis commented Sep 24, 2023

MikeRavenelle commented Sep 24, 2023

mrtuxa commented Sep 25, 2023

Jaskowicz1 commented Nov 2, 2023

Jaskowicz1 commented Nov 13, 2023

Jaskowicz1 commented Nov 13, 2023 • edited Loading

Jaskowicz1 commented Nov 28, 2023

razaqq commented Dec 6, 2023

Jaskowicz1 commented Dec 6, 2023

MikeRavenelle commented Jan 20, 2024

AA1999 commented Jan 23, 2024 • edited Loading

Jaskowicz1 commented May 24, 2024

AA1999 commented Jul 24, 2024

Jaskowicz1 commented Jul 24, 2024

github-actions bot commented Sep 23, 2024

braindigitalis commented Oct 25, 2024

braindigitalis commented Oct 30, 2024

ReallySnazzy commented Mar 25, 2022 •

edited by braindigitalis

Loading

SirLynix commented May 18, 2022 •

edited

Loading

Jaskowicz1 commented Nov 13, 2023 •

edited

Loading

AA1999 commented Jan 23, 2024 •

edited

Loading