Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YlOrRd & YlGnBu colormap typo? #32

Open
afarme3 opened this issue Jan 9, 2023 · 2 comments
Open

YlOrRd & YlGnBu colormap typo? #32

afarme3 opened this issue Jan 9, 2023 · 2 comments

Comments

@afarme3
Copy link

afarme3 commented Jan 9, 2023

Hello,
I have been using this library for colormapping geospatial data in OpenLayers - with an option for the user to choose between any of the colormaps available.

In the reference image, there are colormaps 'YlOrRd' and 'YlGnBu' , which I had removed because using this string for retrieving a colormap had thrown an error that the colormap did not exist.

Looking at colorScale.js , it looks like these are actually stored as 'yiorrd' and 'yignbu' - is the 'l' actually supposed to be an 'i'? 'RdBu' is also capitalized in the image and lowercase in the code.

Either this is a typo on the implementation end, or a typo on the reference image. With no user reference other than the image for the names to use for colormaps, this had me confused.

Could you please either update the naming in the code or in the image? Thank you.

@endolith
Copy link

endolith commented Jan 9, 2023

It should be YlOrRd, YlGnBu, etc. (Yl = "Yellow") See https://colorbrewer2.org/export/colorbrewer.css

@nickyonge
Copy link

Seconded. This is still an issue. Was getting wonky errors until I found this and changed my local reference from YlOrRd to YIOrRd, which works, but is obnoxious 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants