-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Ruff rule EXE001 (shebang-not-executable) #899
fix: Ruff rule EXE001 (shebang-not-executable) #899
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry :-(
After a 2nd review, I realized that It should be exactly the opposite: remove that shebang from all non-executable files.
Only zxbc.py, zxbasm.py and zxbpp.py (in root folder and src/ sub-folders) should be executable. The rest should be imported.
OK, cool. No worries. I am modifying the PR. |
ec9de08
to
2103037
Compare
Note that the following files are also defining a shebang but they are executable:
|
And this is ok. The only ones that should not have a shebang for sure are the |
https://docs.astral.sh/ruff/rules/shebang-not-executable/