Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

borgmatic_hooks indentation broken in rendered config #157

Open
TheAssassin opened this issue Nov 7, 2024 · 3 comments · May be fixed by #159
Open

borgmatic_hooks indentation broken in rendered config #157

TheAssassin opened this issue Nov 7, 2024 · 3 comments · May be fixed by #159
Assignees
@m3nu
Labels
type:bug

Comments

@TheAssassin
Copy link

After #155, the indentation of borgmatic_hooks is broken. The hooks now live on the root indentation level and are no longer children of hooks: in the rendered configuration file.

Using 1.1.0 works fine. I'm not sure what the motivation behind #155 was, but it introduced this regression.

The obvious fix is to use | indent(4) or similar on the {{ hooks }} line, too, I suppose.
@holzi1005
Copy link

I have the same issue. The borgmatic_hooks do not look good and will result in an error.

@m3nu
Copy link
Collaborator

m3nu commented Nov 21, 2024

True. I also had to correct this a few times.

@m3nu m3nu added the type:bug label Nov 21, 2024
@m3nu m3nu self-assigned this Nov 23, 2024
@m3nu m3nu linked a pull request Nov 23, 2024 that will close this issue
Open
@m3nu
Copy link
Collaborator

m3nu commented Nov 23, 2024

Added very simple PR. Would be great if someone can confirm this works for their case. Result of my test:

Screenshot 2024-11-23 at 14 50 14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@m3nu m3nu

Labels
type:bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Indent hook name m3nu/ansible-role-borgbackup
3 participants
@m3nu @TheAssassin @holzi1005