Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make releases dropdown form method GET instead of POST #1419

Closed
GregKaleka opened this issue Nov 6, 2024 · 2 comments
Closed

Make releases dropdown form method GET instead of POST #1419

GregKaleka opened this issue Nov 6, 2024 · 2 comments
Assignees
Labels
Maintenance Things that need updated

Comments

@GregKaleka
Copy link
Collaborator

GregKaleka commented Nov 6, 2024

On the /releases/ page, the version dropdown form performs a POST request, which is a bit silly. We should change this form to perform a GET request.

@sdarwin
Copy link
Collaborator

sdarwin commented Nov 6, 2024

On this point, just to clarify, Django automatically adds a csrf_token to forms with method="POST". If we change it to GET, then new users will not see the csrf token in the first place. That obviously won't remove cookies for users who visited the site before such a change.

That is probably often the case. And it's a very good point!

At the same time... I was able to remove the csrf_token from a few pages (including the one under discussion, I believe.) See https://github.com/boostorg/website-v2/pull/1073/files . So that issue should be solved.

if switching from POST to GET doesn't cause the URL in the browser bar to add many extra variables.... then this update could still be done

@daveoconnor
Copy link
Collaborator

Closing this as it is now a GET request as part of the version/category select consolidation and url changes.

@github-project-automation github-project-automation bot moved this from Accepted to Done in website-v2 Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance Things that need updated
Projects
Status: Done
Development

No branches or pull requests

4 participants