Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ToC not displaying on iOS mobile #359

Closed
rbbeeston opened this issue Nov 11, 2024 · 3 comments
Closed

ToC not displaying on iOS mobile #359

rbbeeston opened this issue Nov 11, 2024 · 3 comments
Assignees
@daveoconnor @julioest
Labels
Bug A problem with the UI or stylesheets HTML/CSS The issue pertains to the html templates or stylesheets.

Comments

@rbbeeston
Copy link
Member

when looking at iOS mobile, the docs ToC isn't appearing:
Image
@rbbeeston rbbeeston converted this from a draft issue Nov 11, 2024
@rbbeeston rbbeeston added Bug A problem with the UI or stylesheets HTML/CSS The issue pertains to the html templates or stylesheets. labels Nov 11, 2024
@julioest
Copy link
Collaborator

julioest commented Nov 11, 2024 •
edited
Loading

This happens because of conflicting styles inside the boostbookV2.css. In the screenshot, once I block the resource it fixes itself.

@daveoconnor We should also check these types of pages, similar to what we did for the learn docs. Here’s the example we're referencing: https://www.boost.io/doc/libs/develop/doc/antora/url/index.html

Image

@rbbeeston rbbeeston assigned daveoconnor and unassigned julioest Nov 11, 2024
@daveoconnor
Copy link
Collaborator

Talked to @julioest about this, and it seems to be working on staging as is, but we're going to make some changes anyway.

Active PR for this work is boostorg/website-v2#1460

@daveoconnor daveoconnor moved this from Accepted to In Progress in website-v2 Nov 18, 2024
julioest added a commit to julioest/boostlook that referenced this issue Nov 20, 2024
@julioest
enhance boostlook layout and fix toc display on mobile
cb8e178 
- added padding and border-radius to #header, #content, and #footer
- refactored TOC with fixed position and overflow
- implemented conditional footer padding using :has()
- added media query for responsive border-radius on #content
- fixed TOC not displaying on mobile devices

addresses boostorg/website-v2-docs#359
@julioest julioest mentioned this issue Nov 20, 2024
Merged
julioest added a commit to julioest/boostlook that referenced this issue Nov 22, 2024
@julioest
enhance boostlook layout and fix toc display on mobile
f3b0d43 
- added padding and border-radius to #header, #content, and #footer
- refactored TOC with fixed position and overflow
- implemented conditional footer padding using :has()
- added media query for responsive border-radius on #content
- fixed TOC not displaying on mobile devices

addresses boostorg/website-v2-docs#359
julioest added a commit to julioest/boostlook that referenced this issue Nov 22, 2024
@julioest
enhance boostlook layout and fix toc display on mobile
2381aef 
- added padding and border-radius to #header, #content, and #footer
- refactored TOC with fixed position and overflow
- implemented conditional footer padding using :has()
- added media query for responsive border-radius on #content
- fixed TOC not displaying on mobile devices

addresses boostorg/website-v2-docs#359
julioest added a commit to boostorg/boostlook that referenced this issue Nov 22, 2024
@julioest
enhance boostlook layout and fix toc display on mobile
43fc4a9 
- added padding and border-radius to #header, #content, and #footer
- refactored TOC with fixed position and overflow
- implemented conditional footer padding using :has()
- added media query for responsive border-radius on #content
- fixed TOC not displaying on mobile devices

addresses boostorg/website-v2-docs#359
julioest added a commit to julioest/boostlook that referenced this issue Nov 22, 2024
@julioest
enhance boostlook layout and fix toc display on mobile
231bc2a 
- added padding and border-radius to #header, #content, and #footer
- refactored TOC with fixed position and overflow
- implemented conditional footer padding using :has()
- added media query for responsive border-radius on #content
- fixed TOC not displaying on mobile devices

addresses boostorg/website-v2-docs#359
julioest added a commit to boostorg/boostlook that referenced this issue Nov 22, 2024
@julioest
enhance boostlook layout and fix toc display on mobile
c28cc72 
- added padding and border-radius to #header, #content, and #footer
- refactored TOC with fixed position and overflow
- implemented conditional footer padding using :has()
- added media query for responsive border-radius on #content
- fixed TOC not displaying on mobile devices

addresses boostorg/website-v2-docs#359
julioest added a commit to julioest/website-v2 that referenced this issue Nov 23, 2024
@julioest
refine TOC positioning for legacy docs wrapper based on article presence
7ebe982 
This is antora-specific. Addresses issue boostorg/website-v2-docs/issues/359
@julioest julioest mentioned this issue Nov 23, 2024
Merged
@daveoconnor daveoconnor moved this from In Progress to Done in website-v2 Nov 25, 2024
@julioest
Copy link
Collaborator

This issue has been resolved:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@daveoconnor daveoconnor

@julioest julioest

Labels
Bug A problem with the UI or stylesheets HTML/CSS The issue pertains to the html templates or stylesheets.
Projects
website-v2
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@daveoconnor @julioest @rbbeeston