-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modernize noexcept specifications #1191
Conversation
b37ad5d
to
408fcbc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, indeed C++14 syntax is fine now
One thing, @vissarion , is it better to split it into two commits? |
include/boost/geometry/algorithms/detail/overlay/get_turn_info.hpp
Outdated
Show resolved
Hide resolved
408fcbc
to
3502521
Compare
I have split the changes into two commits and removed the dtors as requested |
@georgthegreat Since you removed the unneded destructors would you be willing to make some other related improvements as well or would you prefer to merge this as it is? The improvements I'm thinking about are:
|
@awulkiew, I am ok with doing this, but I want this PR merged without this change. |
Thanks for splitting it. |
Let's merge it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@awulkiew, virtual -> override replacement is here: |
As boost::geometry mandates C++14 since 1.75, I assume this can be merged in C++03-incompatible form.