You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It looks like there may be a slight design flaw here - but before I open a PR to attempt to fix this, I'm curious whether or not this is truly intentional. So I figured I'd open an issue and see what others thought.
From what I can tell, there's a method on an order called avalara_tax_enabled? defined here which seems to be used in a few places to help determine whether or not tax should be calculated for a given order. But... in the tax calculator, this method is not used, and instead we just check the overall tax configuration.
It seems like this method is intended to be a hook for applications to write code that allows for saying "disable taxes for this order", but that obviously won't work as written. I'm not sure if this is an intentional choice in the gem, or an oversight, or a bug, or some combination of all three!
The text was updated successfully, but these errors were encountered:
That line was introduced by this commit. Previously, the method avalara_tax_enabled? was called avalara_eligible? but was not used. In my opinion, I think it's just an oversight. Anyway, I think it's reasonable to align also that to use the avalara_tax_enabled? method.
Additionally, the avalara_tax_enabled? Method is replicated in many different models, so maybe it's better to refactor the code to centralize the method in a single place?
It looks like there may be a slight design flaw here - but before I open a PR to attempt to fix this, I'm curious whether or not this is truly intentional. So I figured I'd open an issue and see what others thought.
From what I can tell, there's a method on an order called
avalara_tax_enabled?
defined here which seems to be used in a few places to help determine whether or not tax should be calculated for a given order. But... in the tax calculator, this method is not used, and instead we just check the overall tax configuration.It seems like this method is intended to be a hook for applications to write code that allows for saying "disable taxes for this order", but that obviously won't work as written. I'm not sure if this is an intentional choice in the gem, or an oversight, or a bug, or some combination of all three!
The text was updated successfully, but these errors were encountered: